Hi,
the attached patch adds support for the Epson 8564 RTC
chip. This chip is a generic real-time-clock sitting on
a I2C bus.
Patch URL:
http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch
Please comment,
Stefan E.
--
Eletztrick Computing - Customized Linux Development
Stefan Eletzhofer, Marktstrasse 43, DE-88214 Ravensburg
http://www.eletztrick.de
On Wed, Apr 28, 2004 at 03:41:22PM +0200, Stefan Eletzhofer wrote:
> Hi,
> the attached patch adds support for the Epson 8564 RTC
> chip. This chip is a generic real-time-clock sitting on
> a I2C bus.
Duh, it's against 2.6.6-rc2 :)
>
> Patch URL:
> http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch
>
> Please comment,
> Stefan E.
>
>
Hi,
FYI alle deine Mails kommen immer 2x auf der LKML an. Solltest du mal bei
Gelegenheit untersuchen. Mir ists egal aber es gibt immer ein paar Dödel die
dann nichts besseres zu tun haben als sich zu Ärgern ;-)
Grüsse,
Florian
On Wednesday 28 April 2004 15:41, [email protected] wrote:
> Hi,
> the attached patch adds support for the Epson 8564 RTC
> chip. This chip is a generic real-time-clock sitting on
> a I2C bus.
>
> Patch URL:
> http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch
>
> Please comment,
> Stefan E.
Hi Stefan,
Just a quick comment about your patch: it's a common habit of the
sensors folks to prefix i2c bus drivers with i2c-, but not chip
drivers. So I would suggest that you name your driver rtc8564, not
i2c-rtc8564.
Also, please keep the lines in drivers/i2c/chips/Makefile in the
alphabetic order. And your header states
"linux/drivers/system3/rtc8564.c" while the driver will be in a
different location. Please correct.
I've not read your code otherwise, I don't know anything about RTCs.
Thanks.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
On Wed, Apr 28, 2004 at 05:06:13PM +0200, Jean Delvare wrote:
> Hi Stefan,
>
> Just a quick comment about your patch: it's a common habit of the
> sensors folks to prefix i2c bus drivers with i2c-, but not chip
> drivers. So I would suggest that you name your driver rtc8564, not
> i2c-rtc8564.
Ok, I'll fix that.
>
> Also, please keep the lines in drivers/i2c/chips/Makefile in the
> alphabetic order.
... and that one
> And your header states
> "linux/drivers/system3/rtc8564.c" while the driver will be in a
> different location. Please correct.
And that too.
> I've not read your code otherwise, I don't know anything about RTCs.
>
> Thanks.
>
> --
> Jean Delvare
> http://www.ensicaen.ismra.fr/~delvare/
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Eletztrick Computing - Customized Linux Development
Stefan Eletzhofer, Marktstrasse 43, DE-88214 Ravensburg
http://www.eletztrick.de
Hi,
here's a updated patch which adds support for the RTC
8564 Chip from Epson. This is a RTC chip sitting on a
I2C bus.
The patch is against 2.6.6-rc3.
I've removed the "i2c-" part of the file names, and updated
the comments in the file headers.
The Makefile is now kept sorted, too.
Please comment,
Stefan E.
Patch URL:
http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch
--
Eletztrick Computing - Customized Linux Development
Stefan Eletzhofer, Marktstrasse 43, DE-88214 Ravensburg
http://www.eletztrick.de