--
J'qbpbe, le m'en fquz pe j'qbpbe!
Le veux aimeb et mqubib panz je p?zqbpbe je djuz tqtaj!
On Wed, 02 Jun 2004 at 11:19 +0000, Jens Schmalzing wrote:
> Hi,
>
> I noticed that the driver for the OProfile profiling system, which
> existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> even though the driver still exists. Is there a reason for this? The
> attached patch re-enables the driver.
I don't remember any reason, no test box perhaps ?
The patch looks fine
regards,
Phil
On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
> Hi,
>
> I noticed that the driver for the OProfile profiling system, which
> existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> even though the driver still exists. Is there a reason for this? The
> attached patch re-enables the driver.
Because it has never been picked up, aside from when Ben took it into
his tree (assuming this is the patch Anton wrote a while back, and not
a re-write Ben did). BTW, this is missing a hunk I think, unless the
arch/ppc/kernel/time.c changes have already made it in.
--
Tom Rini
http://gate.crashing.org/~trini/
On Wed, 02 Jun 2004 at 08:50 +0000, Tom Rini wrote:
> On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
>
> > Hi,
> >
> > I noticed that the driver for the OProfile profiling system, which
> > existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
> > even though the driver still exists. Is there a reason for this? The
> > attached patch re-enables the driver.
>
> Because it has never been picked up, aside from when Ben took it into
> his tree (assuming this is the patch Anton wrote a while back, and not
> a re-write Ben did). BTW, this is missing a hunk I think, unless the
> arch/ppc/kernel/time.c changes have already made it in.
Right there is a missing call to profile_hook(regs); in ppc_do_profile()
regards,
Phil
Philippe Elie wrote:
>On Wed, 02 Jun 2004 at 08:50 +0000, Tom Rini wrote:
>
>
>
>>On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
>>
>>
>>
>>>Hi,
>>>
>>>I noticed that the driver for the OProfile profiling system, which
>>>existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
>>>even though the driver still exists. Is there a reason for this? The
>>>attached patch re-enables the driver.
>>>
>>>
>>Because it has never been picked up, aside from when Ben took it into
>>his tree (assuming this is the patch Anton wrote a while back, and not
>>a re-write Ben did). BTW, this is missing a hunk I think, unless the
>>arch/ppc/kernel/time.c changes have already made it in.
>>
>>
>
>Right there is a missing call to profile_hook(regs); in ppc_do_profile()
>
>
The patch I've been using for ppc oprofile is archived here.
http://www.cs.helsinki.fi/linux/linux-kernel/2003-09/1228.html
I've always wondered why it never got picked up.
Greg Weeks
Hi,
Tom Rini writes:
> BTW, this is missing a hunk I think, unless the
> arch/ppc/kernel/time.c changes have already made it in.
Of course you are correct. Greg Weeks already posted a link to the
complete patch.
Regards, Jens.
--
J'qbpbe, le m'en fquz pe j'qbpbe!
Le veux aimeb et mqubib panz je p?zqbpbe je djuz tqtaj!