Hello,
linus.patch from -mm1:
# BitKeeper/deleted/.del-802_11.h~9b6bd4cff8af7a90
# 2004/06/18 09:47:58-07:00 [email protected] +0 -0
# Delete: include/linux/802_11.h
Why was this file removed? The IPW2100 driver
(http://ipw2100.sourceforge.net) uses its definitions and now won't build
against -bk or -mm kernel source.
--
Joshua Kwan
Joshua Kwan <[email protected]> wrote:
>
> Hello,
>
> linus.patch from -mm1:
> # BitKeeper/deleted/.del-802_11.h~9b6bd4cff8af7a90
> # 2004/06/18 09:47:58-07:00 [email protected] +0 -0
> # Delete: include/linux/802_11.h
>
> Why was this file removed?
Nothing in the kernel is using it.
> The IPW2100 driver
> (http://ipw2100.sourceforge.net) uses its definitions and now won't build
> against -bk or -mm kernel source.
Jean, should we restore 802_11.h, or is there some alternative file which
that driver should be using?
On Mon, Jun 21, 2004 at 05:38:27PM -0700, Andrew Morton wrote:
> Joshua Kwan <[email protected]> wrote:
> >
> > Hello,
> >
> > linus.patch from -mm1:
> > # BitKeeper/deleted/.del-802_11.h~9b6bd4cff8af7a90
> > # 2004/06/18 09:47:58-07:00 [email protected] +0 -0
> > # Delete: include/linux/802_11.h
> >
> > Why was this file removed?
>
> Nothing in the kernel is using it.
It was a remnant from the old aironet4500 driver that was
removed during 2.5.X. It was also confusing because there is a file
called drivers/net/wireless/ieee802_11.h that has a somewhat similar
purpose and is used in various drivers (Orinoco, Atmel). I think it
was discussed on netdev.
I was not aware that IPW2100 was using it. I could not try
this driver because it doesn't compile with gcc 2.95.
> > The IPW2100 driver
> > (http://ipw2100.sourceforge.net) uses its definitions and now won't build
> > against -bk or -mm kernel source.
>
> Jean, should we restore 802_11.h, or is there some alternative file which
> that driver should be using?
Well, Jeff explicitely said that we should not care about
drivers outside the kernel ;-)
Seriously, I see three solutions :
1) Convert ipw2100 to using drivers/net/wireless/ieee802_11.h,
extend this header as necessary
2) Have ipw2100 use a private version of 802_11.h
3) Convince us that this file is really needed (good luck)
Obviously (1) is better in the long term.
Have fun...
Jean
Jean Tourrilhes wrote:
>On Mon, Jun 21, 2004 at 05:38:27PM -0700, Andrew Morton wrote:
>
>
>>Joshua Kwan <[email protected]> wrote:
>>
>>
>>>The IPW2100 driver
>>>(http://ipw2100.sourceforge.net) uses its definitions and now won't build
>>>against -bk or -mm kernel source.
>>>
>>>
>>Jean, should we restore 802_11.h, or is there some alternative file which
>>that driver should be using?
>>
>>
>
> Well, Jeff explicitely said that we should not care about
>drivers outside the kernel ;-)
> Seriously, I see three solutions :
> 1) Convert ipw2100 to using drivers/net/wireless/ieee802_11.h,
>extend this header as necessary
>
>
This is the path I was planning to take when I read about 802_11.h
possibly going away a while ago. The file finally going away will just
raise the priority of that effort a bit :) Changing the code to use the
headers in drivers/net/wireless isn't a big task -- I'll put the change
into the next snapshot of ipw2100.
Thanks,
James
(of ipw2100.sf.net)
On Tue, Jun 22, 2004 at 08:39:44PM -0500, James Ketrenos wrote:
> Jean Tourrilhes wrote:
>
> >On Mon, Jun 21, 2004 at 05:38:27PM -0700, Andrew Morton wrote:
> >
> >
> >>Joshua Kwan <[email protected]> wrote:
> >>
> >>
> >>>The IPW2100 driver
> >>>(http://ipw2100.sourceforge.net) uses its definitions and now won't build
> >>>against -bk or -mm kernel source.
> >>>
> >>>
> >>Jean, should we restore 802_11.h, or is there some alternative file which
> >>that driver should be using?
> >>
> >>
> >
> > Well, Jeff explicitely said that we should not care about
> >drivers outside the kernel ;-)
> > Seriously, I see three solutions :
> > 1) Convert ipw2100 to using drivers/net/wireless/ieee802_11.h,
> >extend this header as necessary
> >
> >
> This is the path I was planning to take when I read about 802_11.h
> possibly going away a while ago. The file finally going away will just
> raise the priority of that effort a bit :) Changing the code to use the
> headers in drivers/net/wireless isn't a big task -- I'll put the change
> into the next snapshot of ipw2100.
Nice. I saw that Joshua already sent a patch on your mailing
list.
BTW, I'm not the one maintaining ieee802_11.h, it was
originally created by David Gibson as part of the Orinoco driver. So,
if there is something you don't like in it, you may want to contact
him.
> Thanks,
> James
Have fun...
Jean