2004-06-23 12:57:51

by Pete Clements

Subject: 2.6.7-bk6 fails module compile -- iptable_raw.c

FYI: (gcc version 2.95.4)

CC [M] net/ipv4/netfilter/iptable_raw.o
net/ipv4/netfilter/iptable_raw.c:57: unknown field `target_size' specified in initializer
net/ipv4/netfilter/iptable_raw.c:57: warning: missing braces around initializer
net/ipv4/netfilter/iptable_raw.c:57: warning: (near initialization for `initial_table.entries[0].target.target.u')
net/ipv4/netfilter/iptable_raw.c:71: unknown field `target_size' specified in initializer
net/ipv4/netfilter/iptable_raw.c:85: unknown field `user' specified in initializer
net/ipv4/netfilter/iptable_raw.c:87: unknown field `name' specified in initializer
net/ipv4/netfilter/iptable_raw.c:87: warning: excess elements in union initializer
net/ipv4/netfilter/iptable_raw.c:87: warning: (near initialization for `initial_table.term.target.target.u')
make[3]: *** [net/ipv4/netfilter/iptable_raw.o] Error 1
make[2]: *** [net/ipv4/netfilter] Error 2
make[1]: *** [net/ipv4] Error 2
make: *** [net] Error 2

--
Pete Clements

2004-06-23 13:41:07

by YOSHIFUJI Hideaki

Subject: Re: 2.6.7-bk6 fails module compile -- iptable_raw.c

In article <[email protected]> (at Wed, 23 Jun 2004 08:56:08 -0400 (EDT)), Pete Clements <[email protected]> says:

> FYI: (gcc version 2.95.4)
>
> CC [M] net/ipv4/netfilter/iptable_raw.o
> net/ipv4/netfilter/iptable_raw.c:57: unknown field `target_size' specified in initializer
> net/ipv4/netfilter/iptable_raw.c:57: warning: missing braces around initializer
> net/ipv4/netfilter/iptable_raw.c:57: warning: (near initialization for `initial_table.entries[0].target.target.u')
> net/ipv4/netfilter/iptable_raw.c:71: unknown field `target_size' specified in initializer
> net/ipv4/netfilter/iptable_raw.c:85: unknown field `user' specified in initializer
> net/ipv4/netfilter/iptable_raw.c:87: unknown field `name' specified in initializer
> net/ipv4/netfilter/iptable_raw.c:87: warning: excess elements in union initializer
> net/ipv4/netfilter/iptable_raw.c:87: warning: (near initialization for `initial_table.term.target.target.u')
> make[3]: *** [net/ipv4/netfilter/iptable_raw.o] Error 1
> make[2]: *** [net/ipv4/netfilter] Error 2
> make[1]: *** [net/ipv4] Error 2
> make: *** [net] Error 2

Please try this.

===== net/ipv4/netfilter/iptable_raw.c 1.2 vs edited =====
--- 1.2/net/ipv4/netfilter/iptable_raw.c 2004-06-22 06:39:19 +09:00
+++ edited/net/ipv4/netfilter/iptable_raw.c 2004-06-23 22:35:44 +09:00
@@ -54,7 +54,9 @@
},
.target = {
.target = {
- .u.target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
+ .u = {
+ .target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
+ },
},
.verdict = -NF_ACCEPT - 1,
},
@@ -68,7 +70,9 @@
},
.target = {
.target = {
- .u.target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
+ .u = {
+ .target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
+ },
},
.verdict = -NF_ACCEPT - 1,
},
@@ -82,9 +86,11 @@
},
.target = {
.target = {
- .u.user = {
- .target_size = IPT_ALIGN(sizeof(struct ipt_error_target)),
- .name = IPT_ERROR_TARGET,
+ .u = {
+ .user = {
+ .target_size = IPT_ALIGN(sizeof(struct ipt_error_target)),
+ .name = IPT_ERROR_TARGET,
+ },
},
},
.errorname = "ERROR",

--
Hideaki YOSHIFUJI @ USAGI Project <[email protected]>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA

2004-06-23 14:48:06

by Pete Clements

Subject: Re: 2.6.7-bk6 fails module compile -- iptable_raw.c

Patches and compiles. Thanks.

--
Pete Clements

Quoting YOSHIFUJI Hideaki / [?iso-2022-jp?]
> In article <[email protected]> (at Wed, 23 Jun 2004 08:56:08 -0400 (EDT)), Pete Clements <[email protected]> says:
>
> > FYI: (gcc version 2.95.4)
> >
> > CC [M] net/ipv4/netfilter/iptable_raw.o
> > net/ipv4/netfilter/iptable_raw.c:57: unknown field `target_size' specified in initializer
> > net/ipv4/netfilter/iptable_raw.c:57: warning: missing braces around initializer
> > net/ipv4/netfilter/iptable_raw.c:57: warning: (near initialization for `initial_table.entries[0].target.target.u')
> > net/ipv4/netfilter/iptable_raw.c:71: unknown field `target_size' specified in initializer
> > net/ipv4/netfilter/iptable_raw.c:85: unknown field `user' specified in initializer
> > net/ipv4/netfilter/iptable_raw.c:87: unknown field `name' specified in initializer
> > net/ipv4/netfilter/iptable_raw.c:87: warning: excess elements in union initializer
> > net/ipv4/netfilter/iptable_raw.c:87: warning: (near initialization for `initial_table.term.target.target.u')
> > make[3]: *** [net/ipv4/netfilter/iptable_raw.o] Error 1
> > make[2]: *** [net/ipv4/netfilter] Error 2
> > make[1]: *** [net/ipv4] Error 2
> > make: *** [net] Error 2
>
> Please try this.
>
> ===== net/ipv4/netfilter/iptable_raw.c 1.2 vs edited =====
> --- 1.2/net/ipv4/netfilter/iptable_raw.c 2004-06-22 06:39:19 +09:00
> +++ edited/net/ipv4/netfilter/iptable_raw.c 2004-06-23 22:35:44 +09:00
> @@ -54,7 +54,9 @@
> },
> .target = {
> .target = {
> - .u.target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
> + .u = {
> + .target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
> + },
> },
> .verdict = -NF_ACCEPT - 1,
> },
> @@ -68,7 +70,9 @@
> },
> .target = {
> .target = {
> - .u.target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
> + .u = {
> + .target_size = IPT_ALIGN(sizeof(struct ipt_standard_target)),
> + },
> },
> .verdict = -NF_ACCEPT - 1,
> },
> @@ -82,9 +86,11 @@
> },
> .target = {
> .target = {
> - .u.user = {
> - .target_size = IPT_ALIGN(sizeof(struct ipt_error_target)),
> - .name = IPT_ERROR_TARGET,
> + .u = {
> + .user = {
> + .target_size = IPT_ALIGN(sizeof(struct ipt_error_target)),
> + .name = IPT_ERROR_TARGET,
> + },
> },
> },
> .errorname = "ERROR",
>

2004-06-23 15:01:24

by David Miller

Subject: Re: 2.6.7-bk6 fails module compile -- iptable_raw.c

On Wed, 23 Jun 2004 22:42:03 +0900 (JST)
YOSHIFUJI Hideaki / $B5HF#1QL@(B <[email protected]> wrote:

> > net/ipv4/netfilter/iptable_raw.c:57: unknown field `target_size' specified in initializer
...
> Please try this.
>
> ===== net/ipv4/netfilter/iptable_raw.c 1.2 vs edited =====
> --- 1.2/net/ipv4/netfilter/iptable_raw.c 2004-06-22 06:39:19 +09:00
> +++ edited/net/ipv4/netfilter/iptable_raw.c 2004-06-23 22:35:44 +09:00

Applied, thanks.