2004-06-30 03:54:48

by linas

[permalink] [raw]
Subject: [PATCH] PPC64: Janitor log_rtas_error() call arguments



Paul,

Please apply the following patch to the ameslab tree and/or forward to
the official 2.6 tree maintainers, as appropriate. This patch fixes the
confusing argument aliasing of the log_rtas_error() subroutine.

This patch makes no functional changes, it just cleans up some
strange usage.

The rtas_args used to communicate with firmware are always taken
from the paca struct, so as to keep the args at a fixed, low-memory
location. But the log_rtas_error() routine also took an rtas_args
pointer, which it assumed was aliased to the paca struct. This
aliasing is both un-neccessary, and confusing; this patch eliminates
this confusion.

Signed-off-by: Linas Vepstas <[email protected]>

--linas


Attachments:
(No filename) (708.00 B)
rtas-args-aliasing.patch (1.76 kB)
Download all attachments