2004-09-01 16:50:07

by Dave Jones

[permalink] [raw]
Subject: [PATCH] Fix NULL derefence in OSS MAUI driver.

Spotted with the source checker from Coverity.com.

Signed-off-by: Dave Jones <[email protected]>


diff -urpN --exclude-from=/home/davej/.exclude bk-linus/sound/oss/maui.c linux-2.6/sound/oss/maui.c
--- bk-linus/sound/oss/maui.c 2004-08-28 21:57:25.000000000 +0100
+++ linux-2.6/sound/oss/maui.c 2004-09-01 13:31:21.000000000 +0100
@@ -383,9 +383,8 @@ static int __init probe_maui(struct addr
*/

synth = midi_devs[this_dev]->converter;
- synth->id = "MAUI";
-
if (synth != NULL) {
+ synth->id = "MAUI";
orig_load_patch = synth->load_patch;
synth->load_patch = &maui_load_patch;
} else