2004-09-01 16:21:03

by Dave Jones

Subject: [PATCH] Check find_vma return code in make_pages_present()

It can return NULL, so check for it.

Spotted with the source checker from Coverity.com.

Signed-off-by: Dave Jones <[email protected]>


diff -urpN --exclude-from=/home/davej/.exclude bk-linus/mm/memory.c linux-2.6/mm/memory.c
--- bk-linus/mm/memory.c 2004-08-24 00:02:41.000000000 +0100
+++ linux-2.6/mm/memory.c 2004-09-01 13:31:18.000000000 +0100
@@ -1744,6 +1744,8 @@ int make_pages_present(unsigned long add
struct vm_area_struct * vma;

vma = find_vma(current->mm, addr);
+ if (!vma)
+ return -1;
write = (vma->vm_flags & VM_WRITE) != 0;
if (addr >= end)
BUG();