2004-09-01 18:40:56

by Peter Osterlund

[permalink] [raw]
Subject: Re: [PATCH] DVD+RW support for 2.6.7-bk13

Peter Osterlund <[email protected]> writes:

> This patch adds support for using DVD+RW drives as writable block
> devices under the 2.6.7-bk13 kernel.
>
> The patch is based on work from:
>
> Andy Polyakov <[email protected]> - Wrote the 2.4 patch
> Nigel Kukard <[email protected]> - Initial porting to 2.6.x
...
> linux-petero/drivers/cdrom/cdrom.c | 80 +++++++++++++++++++++++++++++++++++++
> linux-petero/drivers/ide/ide-cd.c | 2
> linux-petero/drivers/scsi/sr.c | 1
> linux-petero/include/linux/cdrom.h | 2

Nigel pointed out that the earlier patches contained attributions that
are not present in this patch. The 2.4 patch contains:

Nov 5 2001, Aug 8 2002. Modified by Andy Polyakov
<[email protected]> to support MMC-3 complaint DVD+RW units.

and Nigel changed it to this in his 2.6 patch:

Modified by Nigel Kukard <[email protected]> - support DVD+RW
2.4.x patch by Andy Polyakov <[email protected]>

The patch I sent you deleted most of the earlier work and moved the
rest to cdrom.c, but the comments were not moved over, since the
earlier authors didn't modify cdrom.c.

Nigel wants to get credit for his work though, so were should we put
those messages? Is this patch acceptable?


linux-petero/drivers/cdrom/cdrom.c | 6 ++++++
1 files changed, 6 insertions(+)

diff -puN drivers/cdrom/cdrom.c~packet-copyright drivers/cdrom/cdrom.c
--- linux/drivers/cdrom/cdrom.c~packet-copyright 2004-09-01 20:03:13.075394816 +0200
+++ linux-petero/drivers/cdrom/cdrom.c 2004-09-01 20:31:57.282275528 +0200
@@ -234,6 +234,12 @@
-- Mt Rainier support
-- DVD-RAM write open fixes

+ Nov 5 2001, Aug 8 2002. Modified by Andy Polyakov
+ <[email protected]> to support MMC-3 compliant DVD+RW units.
+
+ Modified by Nigel Kukard <[email protected]> - support DVD+RW
+ 2.4.x patch by Andy Polyakov <[email protected]>
+
-------------------------------------------------------------------------*/

#define REVISION "Revision: 3.20"
_

--
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340


2004-09-01 18:48:15

by Nigel Kukard

[permalink] [raw]
Subject: Re: [PATCH] DVD+RW support for 2.6.7-bk13

> Nigel pointed out that the earlier patches contained attributions that
> are not present in this patch. The 2.4 patch contains:
>
> Nov 5 2001, Aug 8 2002. Modified by Andy Polyakov
> <[email protected]> to support MMC-3 complaint DVD+RW units.
>
> and Nigel changed it to this in his 2.6 patch:
>
> Modified by Nigel Kukard <[email protected]> - support DVD+RW
> 2.4.x patch by Andy Polyakov <[email protected]>
>
> The patch I sent you deleted most of the earlier work and moved the
> rest to cdrom.c, but the comments were not moved over, since the
> earlier authors didn't modify cdrom.c.
>
> Nigel wants to get credit for his work though, so were should we put
> those messages? Is this patch acceptable?
>

Thanks Peter ;-)


Andy wrote the support for 2.4, I basically ported it to 2.6. Make sure
you included aswell though, your help is greatly appreciated!

Everyone, enjoy your day!

-Nigel


>
> linux-petero/drivers/cdrom/cdrom.c | 6 ++++++
> 1 files changed, 6 insertions(+)
>
> diff -puN drivers/cdrom/cdrom.c~packet-copyright drivers/cdrom/cdrom.c
> --- linux/drivers/cdrom/cdrom.c~packet-copyright 2004-09-01 20:03:13.075394816 +0200
> +++ linux-petero/drivers/cdrom/cdrom.c 2004-09-01 20:31:57.282275528 +0200
> @@ -234,6 +234,12 @@
> -- Mt Rainier support
> -- DVD-RAM write open fixes
>
> + Nov 5 2001, Aug 8 2002. Modified by Andy Polyakov
> + <[email protected]> to support MMC-3 compliant DVD+RW units.
> +
> + Modified by Nigel Kukard <[email protected]> - support DVD+RW
> + 2.4.x patch by Andy Polyakov <[email protected]>
> +
> -------------------------------------------------------------------------*/
>
> #define REVISION "Revision: 3.20"
> _


Attachments:
(No filename) (1.68 kB)
(No filename) (189.00 B)
Download all attachments