2004-09-03 21:19:04

by Dave Jones

[permalink] [raw]
Subject: Pointer dereference before NULL check in ACPI thermal driver.

Again, found with coverity's checker.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6.8/drivers/acpi/thermal.c~ 2004-09-03 22:11:22.630428496 +0100
+++ linux-2.6.8/drivers/acpi/thermal.c 2004-09-03 22:11:44.392120216 +0100
@@ -659,7 +659,7 @@
struct acpi_thermal *tz = (struct acpi_thermal *) data;
unsigned long sleep_time = 0;
int i = 0;
- struct acpi_thermal_state state = tz->state;
+ struct acpi_thermal_state state;

ACPI_FUNCTION_TRACE("acpi_thermal_check");

@@ -668,6 +668,8 @@
return_VOID;
}

+ state = tz->state;
+
result = acpi_thermal_get_temperature(tz);
if (result)
return_VOID;