2004-09-06 17:50:00

by Blaisorblade

[permalink] [raw]
Subject: [patch 2/3] uml-ubd-any-elevator


Avoid forcing use of the no-op scheduler for UBD; this may uncover some bugs in the
UBD driver, and in fact uml-ubd-no-empty-queue.patch is needed to make this sure.
But as of now, no other bugs have been discovered, so this should be safe.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[email protected]>
---

uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c | 2 --
1 files changed, 2 deletions(-)

diff -puN arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator arch/um/drivers/ubd_kern.c
--- uml-linux-2.6.8.1/arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator 2004-08-29 14:40:53.731043416 +0200
+++ uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c 2004-08-29 14:40:53.733043112 +0200
@@ -749,8 +749,6 @@ int ubd_init(void)
return -1;
}

- elevator_init(ubd_queue, &elevator_noop);
-
if (fake_major != MAJOR_NR) {
char name[sizeof("ubd_nnn\0")];

_


2004-09-08 09:27:24

by Jens Axboe

[permalink] [raw]
Subject: Re: [patch 2/3] uml-ubd-any-elevator

On Mon, Sep 06 2004, [email protected] wrote:
> diff -puN arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator arch/um/drivers/ubd_kern.c
> --- uml-linux-2.6.8.1/arch/um/drivers/ubd_kern.c~uml-ubd-any-elevator 2004-08-29 14:40:53.731043416 +0200
> +++ uml-linux-2.6.8.1-paolo/arch/um/drivers/ubd_kern.c 2004-08-29 14:40:53.733043112 +0200
> @@ -749,8 +749,6 @@ int ubd_init(void)
> return -1;
> }
>
> - elevator_init(ubd_queue, &elevator_noop);
> -
> if (fake_major != MAJOR_NR) {
> char name[sizeof("ubd_nnn\0")];

if this is not applied, at least the file needs an elevator_exit(q);
before calling elevator_init() for the new elevator. otherwise the
original elevator data is leaked.

--
Jens Axboe