2004-09-09 10:23:19

by Anton Blanchard

[permalink] [raw]
Subject: Current BK breakage


Hi,

Looks like a bug in the cleanup patch :)

Anton

Signed-off-by: Anton Blanchard <[email protected]>

===== buffer.c 1.256 vs edited =====
--- 1.256/fs/buffer.c Wed Sep 8 16:33:15 2004
+++ edited/buffer.c Thu Sep 9 20:03:41 2004
@@ -895,7 +895,7 @@
spin_lock(&buffer_mapping->private_lock);
list_move_tail(&bh->b_assoc_buffers,
&mapping->private_list);
- spin_lock(&buffer_mapping->private_lock);
+ spin_unlock(&buffer_mapping->private_lock);
}

}


2004-09-09 10:56:40

by Andrew Morton

[permalink] [raw]
Subject: Re: Current BK breakage

Anton Blanchard <[email protected]> wrote:
>
> Looks like a bug in the cleanup patch :)

oop. Shows how many people are testing ext2. Let's fix up that whitespace
also.

--- 25/fs/buffer.c~a 2004-09-09 03:53:03.625363720 -0700
+++ 25-akpm/fs/buffer.c 2004-09-09 03:53:17.022327072 -0700
@@ -895,9 +895,8 @@ void mark_buffer_dirty_inode(struct buff
spin_lock(&buffer_mapping->private_lock);
list_move_tail(&bh->b_assoc_buffers,
&mapping->private_list);
- spin_lock(&buffer_mapping->private_lock);
-}
-
+ spin_unlock(&buffer_mapping->private_lock);
+ }
}
EXPORT_SYMBOL(mark_buffer_dirty_inode);

_