2004-09-10 14:18:48

by John Cherry

[permalink] [raw]
Subject: IA32 (2.6.9-rc1 - 2004-09-09.21.30) - 2 New warnings (gcc 3.2.2)

drivers/net/tulip/dmfe.c:1808: warning: passing arg 1 of `__le16_to_cpup' from incompatible pointer type
drivers/net/tulip/dmfe.c:1820: warning: passing arg 1 of `__le32_to_cpup' from incompatible pointer type


2004-09-10 16:31:45

by Al Viro

[permalink] [raw]
Subject: Re: IA32 (2.6.9-rc1 - 2004-09-09.21.30) - 2 New warnings (gcc 3.2.2)

On Fri, Sep 10, 2004 at 07:18:45AM -0700, John Cherry wrote:
> drivers/net/tulip/dmfe.c:1808: warning: passing arg 1 of `__le16_to_cpup' from incompatible pointer type
> drivers/net/tulip/dmfe.c:1820: warning: passing arg 1 of `__le32_to_cpup' from incompatible pointer type

Real alignment bugs, BTW. The first one happens to be OK, but line 1820 is
guaranteed to be misaligned (32bit reads on addresses that differ by 2, so
at least one is guaranteed to fsck up). The value we are calculating there
looks bogus, while we are at it...