2004-09-13 16:46:49

by Badari Pulavarty

Subject: 2.6.9-rc1-mm5 compile errors

Hi Andrew,

I get following compile errors on PPC64 (P3) box while trying
to build 2.6.9-rc1-mm5.

Are these known/fixed ?

Thanks,
Badari

mm/mempolicy.c: In function `get_zonemask':
mm/mempolicy.c:419: error: `maxnode' undeclared (first use in this
function)
mm/mempolicy.c:419: error: (Each undeclared identifier is reported only
once
mm/mempolicy.c:419: error: for each function it appears in.)
arch/ppc64/kernel/pSeries_pci.c: In function `pcibios_fixup_bus':
arch/ppc64/kernel/pSeries_pci.c:607: error: redeclaration of `dev'
arch/ppc64/kernel/pSeries_pci.c:604: error: `dev' previously declared
here
arch/ppc64/kernel/pSeries_pci.c:604: warning: unused variable `dev'
make[1]: *** [arch/ppc64/kernel/pSeries_pci.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [mm/mempolicy.o] Error 1
make: *** [mm] Error 2
make: *** Waiting for unfinished jobs....
arch/ppc64/kernel/pSeries_htab.c: In function
`pSeries_hpte_updateboltedpp':
arch/ppc64/kernel/pSeries_htab.c:243: warning: `flags' might be used
uninitialized in this function
arch/ppc64/kernel/prom.c: In function `map_interrupt':
arch/ppc64/kernel/prom.c:1808: warning: `newintrc' might be used
uninitialized in this function
arch/ppc64/kernel/prom.c:1808: warning: `newaddrc' might be used
uninitialized in this function

2004-09-13 17:08:23

by Paul Jackson

Subject: Re: 2.6.9-rc1-mm5 compile errors

For this error:

mm/mempolicy.c: In function `get_zonemask':
mm/mempolicy.c:419: error: `maxnode' undeclared (first use in this function)
mm/mempolicy.c:419: error: (Each undeclared identifier is reported only once
mm/mempolicy.c:419: error: for each function it appears in.)

See my fix on posted 4 hours ago on lkml:

Subject: [PATCH] undo more numa maxnode confusions
Date: Mon, 13 Sep 2004 05:58:48 -0700

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.650.933.1373

2004-09-13 17:35:26

by Anton Blanchard

Subject: Re: 2.6.9-rc1-mm5 compile errors

Hi,

> arch/ppc64/kernel/pSeries_pci.c: In function `pcibios_fixup_bus':
> arch/ppc64/kernel/pSeries_pci.c:607: error: redeclaration of `dev'
> arch/ppc64/kernel/pSeries_pci.c:604: error: `dev' previously declared
> here
> arch/ppc64/kernel/pSeries_pci.c:604: warning: unused variable `dev'

I sent this to Andrew earlier.

Anton

diff -puN arch/ppc64/kernel/pSeries_pci.c~fix_pseries arch/ppc64/kernel/pSeries_pci.c
--- 2.6.9-rc1-mm5/arch/ppc64/kernel/pSeries_pci.c~fix_pseries 2004-09-13 19:58:29.941874428 +1000
+++ 2.6.9-rc1-mm5-anton/arch/ppc64/kernel/pSeries_pci.c 2004-09-13 19:59:21.967773089 +1000
@@ -601,7 +601,6 @@ EXPORT_SYMBOL(pcibios_fixup_device_resou
void __devinit pcibios_fixup_bus(struct pci_bus *bus)
{
struct pci_controller *hose = PCI_GET_PHB_PTR(bus);
- struct pci_dev *dev;

/* XXX or bus->parent? */
struct pci_dev *dev = bus->self;
_

2004-09-13 18:25:42

by Badari Pulavarty

Subject: Re: 2.6.9-rc1-mm5 compile errors

Got it. Worked fine.

Thanks,
Badari

On Mon, 2004-09-13 at 10:07, Paul Jackson wrote:
> For this error:
>
> mm/mempolicy.c: In function `get_zonemask':
> mm/mempolicy.c:419: error: `maxnode' undeclared (first use in this function)
> mm/mempolicy.c:419: error: (Each undeclared identifier is reported only once
> mm/mempolicy.c:419: error: for each function it appears in.)
>
> See my fix on posted 4 hours ago on lkml:
>
> Subject: [PATCH] undo more numa maxnode confusions
> Date: Mon, 13 Sep 2004 05:58:48 -0700

2004-09-13 18:26:15

by Badari Pulavarty

Subject: Re: 2.6.9-rc1-mm5 compile errors

Yep. Need this.

Thanks,
Badari

On Mon, 2004-09-13 at 10:30, Anton Blanchard wrote:
> Hi,
>
> > arch/ppc64/kernel/pSeries_pci.c: In function `pcibios_fixup_bus':
> > arch/ppc64/kernel/pSeries_pci.c:607: error: redeclaration of `dev'
> > arch/ppc64/kernel/pSeries_pci.c:604: error: `dev' previously declared
> > here
> > arch/ppc64/kernel/pSeries_pci.c:604: warning: unused variable `dev'
>
> I sent this to Andrew earlier.
>
> Anton
>
> diff -puN arch/ppc64/kernel/pSeries_pci.c~fix_pseries arch/ppc64/kernel/pSeries_pci.c
> --- 2.6.9-rc1-mm5/arch/ppc64/kernel/pSeries_pci.c~fix_pseries 2004-09-13 19:58:29.941874428 +1000
> +++ 2.6.9-rc1-mm5-anton/arch/ppc64/kernel/pSeries_pci.c 2004-09-13 19:59:21.967773089 +1000
> @@ -601,7 +601,6 @@ EXPORT_SYMBOL(pcibios_fixup_device_resou
> void __devinit pcibios_fixup_bus(struct pci_bus *bus)
> {
> struct pci_controller *hose = PCI_GET_PHB_PTR(bus);
> - struct pci_dev *dev;
>
> /* XXX or bus->parent? */
> struct pci_dev *dev = bus->self;
> _
>