2004-09-17 10:45:44

by Stelian Pop

[permalink] [raw]
Subject: [PATCH] Add sonypi specific events to the input layer

Hi,

The following patch adds some sonypi specific events to the input
layer.

When possible (for KEY_BACK, KEY_HELP, KEY_ZOOM, KEY_CAMERA for example)
I used the existing events, but some events just have no mapping.

Once this patch is accepted (if it is :) ), I will follow with a patch
for sonypi adding full input support for (almost) all the Vaio events.

Thanks,

Stelian.

Signed-off-by: Stelian Pop <[email protected]>

===== linux-2.6/include/linux/input.h 1.50 vs edited =====
--- 1.50/include/linux/input.h 2004-06-06 11:08:11 +02:00
+++ edited/linux-2.6/include/linux/input.h 2004-09-17 10:26:15 +02:00
@@ -473,6 +473,28 @@
#define KEY_INS_LINE 0x1c2
#define KEY_DEL_LINE 0x1c3

+#define KEY_FN 0x1d0
+#define KEY_FN_ESC 0x1d1
+#define KEY_FN_F1 0x1d2
+#define KEY_FN_F2 0x1d3
+#define KEY_FN_F3 0x1d4
+#define KEY_FN_F4 0x1d5
+#define KEY_FN_F5 0x1d6
+#define KEY_FN_F6 0x1d7
+#define KEY_FN_F7 0x1d8
+#define KEY_FN_F8 0x1d9
+#define KEY_FN_F9 0x1da
+#define KEY_FN_F10 0x1db
+#define KEY_FN_F11 0x1dc
+#define KEY_FN_F12 0x1dd
+#define KEY_FN_1 0x1de
+#define KEY_FN_2 0x1df
+#define KEY_FN_D 0x1e0
+#define KEY_FN_E 0x1e1
+#define KEY_FN_F 0x1e2
+#define KEY_FN_S 0x1e3
+#define KEY_FN_B 0x1e4
+
#define KEY_MAX 0x1ff

/*
--
Stelian Pop <[email protected]>


2004-09-21 08:53:35

by Vojtech Pavlik

[permalink] [raw]
Subject: Re: [PATCH] Add sonypi specific events to the input layer

On Fri, Sep 17, 2004 at 12:42:27PM +0200, Stelian Pop wrote:
> Hi,
>
> The following patch adds some sonypi specific events to the input
> layer.
>
> When possible (for KEY_BACK, KEY_HELP, KEY_ZOOM, KEY_CAMERA for example)
> I used the existing events, but some events just have no mapping.
>
> Once this patch is accepted (if it is :) ), I will follow with a patch
> for sonypi adding full input support for (almost) all the Vaio events.
>
> Thanks,
>
> Stelian.
>
> Signed-off-by: Stelian Pop <[email protected]>

Looking at the definitions below - wouldn't it be better to just define
the "FN" key and report everything else as key combinations?

> ===== linux-2.6/include/linux/input.h 1.50 vs edited =====
> --- 1.50/include/linux/input.h 2004-06-06 11:08:11 +02:00
> +++ edited/linux-2.6/include/linux/input.h 2004-09-17 10:26:15 +02:00
> @@ -473,6 +473,28 @@
> #define KEY_INS_LINE 0x1c2
> #define KEY_DEL_LINE 0x1c3
>
> +#define KEY_FN 0x1d0
> +#define KEY_FN_ESC 0x1d1
> +#define KEY_FN_F1 0x1d2
> +#define KEY_FN_F2 0x1d3
> +#define KEY_FN_F3 0x1d4
> +#define KEY_FN_F4 0x1d5
> +#define KEY_FN_F5 0x1d6
> +#define KEY_FN_F6 0x1d7
> +#define KEY_FN_F7 0x1d8
> +#define KEY_FN_F8 0x1d9
> +#define KEY_FN_F9 0x1da
> +#define KEY_FN_F10 0x1db
> +#define KEY_FN_F11 0x1dc
> +#define KEY_FN_F12 0x1dd
> +#define KEY_FN_1 0x1de
> +#define KEY_FN_2 0x1df
> +#define KEY_FN_D 0x1e0
> +#define KEY_FN_E 0x1e1
> +#define KEY_FN_F 0x1e2
> +#define KEY_FN_S 0x1e3
> +#define KEY_FN_B 0x1e4
> +
> #define KEY_MAX 0x1ff
>
> /*
> --
> Stelian Pop <[email protected]>
>

--
Vojtech Pavlik
SuSE Labs, SuSE CR