2004-09-23 00:18:00

by Andrew Morton

[permalink] [raw]
Subject: Re: PATCH: tty ldisc work version 4

Alan Cox <[email protected]> wrote:
>
> New features this time
> - Fix synclink layers - Paul Fulghum
> - Use tty_wakeup internally to tty_io
> - Add initial termios locking
> - Add ldisc hangup method for notification at hangup()
> - Fixed close to wait for running driver side events
>
> The big changes this time are locking/ordering rules for termios changes. As
> well as various feature changes I've also begun commenting n_tty.c so we
> can start tackling the ldisc internal issues.

This gives me "init_dev but no ldisc" when initscripts start playing with
the USB keyboard. The machine then stops.


2004-09-23 05:49:04

by Alan Cox

[permalink] [raw]
Subject: Re: PATCH: tty ldisc work version 4

On Wed, Sep 22, 2004 at 05:21:39PM -0700, Andrew Morton wrote:
> > The big changes this time are locking/ordering rules for termios changes. As
> > well as various feature changes I've also begun commenting n_tty.c so we
> > can start tackling the ldisc internal issues.
>
> This gives me "init_dev but no ldisc" when initscripts start playing with
> the USB keyboard. The machine then stops.

Intriguing. Does this go way if you uncomment the lines below
"Switchg the line discipline back" in tty_io.c.

I'll stick a USB keyboard on my box later today and chase that down.

Alan

2004-09-24 13:43:28

by Paul Fulghum

[permalink] [raw]
Subject: Re: PATCH: tty ldisc work version 4

On Thu, 2004-09-23 at 00:48, Alan Cox wrote:
> On Wed, Sep 22, 2004 at 05:21:39PM -0700, Andrew Morton wrote:
> > This gives me "init_dev but no ldisc" when initscripts start playing with
> > the USB keyboard. The machine then stops.
>
> Intriguing. Does this go way if you uncomment the lines below
> "Switchg the line discipline back" in tty_io.c.
>
> I'll stick a USB keyboard on my box later today and chase that down.

Andrew, Alan:

Did this turn out to be related to the code
in release_dev() that switches back a tty struct
back to N_TTY ldisc before freeing the tty struct?

--
Paul Fulghum
[email protected]

2004-09-24 14:07:13

by Alan

[permalink] [raw]
Subject: Re: PATCH: tty ldisc work version 4

On Gwe, 2004-09-24 at 14:43, Paul Fulghum wrote:
> Did this turn out to be related to the code
> in release_dev() that switches back a tty struct
> back to N_TTY ldisc before freeing the tty struct?

No it was just a stupid mistake in my code. I'll propogate the
other changes back in now I've found it.