In order to make other debuggers use exception notifiers, kprobes
notifier return values are required to be modified. This patch modifies the
return values of kprobes notifier return values in a clean way.
Please let me know your comments.
Thanks
Prasanna
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<[email protected]>
On Thu, Sep 23, 2004 at 11:00:29AM +0530, Prasanna S Panchamukhi wrote:
> In order to make other debuggers use exception notifiers, kprobes
> notifier return values are required to be modified. This patch modifies the
> return values of kprobes notifier return values in a clean way.
It's incompatible to x86-64. If you change anything in exception
notifiers change both.
And I don't really see the sense of inverting the test: NOTIFY_OK
for handling the exception should be as good as NOTIFY_STOP.
-Andi
Hi Andi,
On Thu, Sep 23, 2004 at 10:06:28AM +0200, Andi Kleen wrote:
> On Thu, Sep 23, 2004 at 11:00:29AM +0530, Prasanna S Panchamukhi wrote:
> > In order to make other debuggers use exception notifiers, kprobes
> > notifier return values are required to be modified. This patch modifies the
> > return values of kprobes notifier return values in a clean way.
>
> It's incompatible to x86-64. If you change anything in exception
> notifiers change both.
>
Yes, I will make the changes to x86_64 exception notifiers as well and
send a patch to you.
> And I don't really see the sense of inverting the test: NOTIFY_OK
> for handling the exception should be as good as NOTIFY_STOP.
>
NOTIFY_OK does not stop notifying others registered for the same event.
This was causing problems when Kprobes and KGDB co-exist and KGDB handler
would get involked, when kprobes handler would have already handled its own
breakpoint. NOTIFY_BAD will also work, but returning NOTIFY_BAD would mean
Bad/Veto action. This patch solves the problem by returning NOTIFY_OK | NOTIFY_STOP_MASK in a clean way.
Please let me know your comments.
Thanks
Prasanna
> -Andi
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<[email protected]>
On 23 Sep 2004 10:06:28 +0200
Andi Kleen <[email protected]> wrote:
> On Thu, Sep 23, 2004 at 11:00:29AM +0530, Prasanna S Panchamukhi wrote:
> > In order to make other debuggers use exception notifiers, kprobes
> > notifier return values are required to be modified. This patch modifies the
> > return values of kprobes notifier return values in a clean way.
>
> It's incompatible to x86-64. If you change anything in exception
> notifiers change both.
And please change sparc64 as well, as it has the same exception
notification implemented there as well.
Hi,
As per Andi and David's request, I have updated exception notifiers for x86_64
and sparc64. This patch can been applied over linux-2.6.9-rc2-mm4.
Also KGDB exception notifier handler for x86_64 and
kprobes notifier handler for sparc64 have been updated.
I have only tested this patch on i386 architecture.
Please let me know if you have any issues.
Thanks
Prasanna
On Thu, Sep 23, 2004 at 12:32:50PM -0700, David S. Miller wrote:
> On 23 Sep 2004 10:06:28 +0200
> Andi Kleen <[email protected]> wrote:
>
> > On Thu, Sep 23, 2004 at 11:00:29AM +0530, Prasanna S Panchamukhi wrote:
> > > In order to make other debuggers use exception notifiers, kprobes
> > > notifier return values are required to be modified. This patch modifies the
> > > return values of kprobes notifier return values in a clean way.
> >
> > It's incompatible to x86-64. If you change anything in exception
> > notifiers change both.
>
> And please change sparc64 as well, as it has the same exception
> notification implemented there as well.
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<[email protected]>