The following patches are an update the previous set of xattr
consolidation patches (v2), posted 18/09.
Changes since then:
- Address listxattr race using patch from Andreas Gruenbacher
- Update ->list methods: ext3 & ext2 now only make one pass over the
xattr handlers.
- Add documentation (with minor modifications) by Will Dyson.
- Changed coding style to match the rest of fs/xattr.c
- Update LSM inode_listsecurity hook with length of list buffer.
- Retested everything.
Please review and apply if ok.
- James
--
James Morris
<[email protected]>
Looks good IMO -- thanks, James.
There is one minor issue in the ext[23]_xattr_list changes: The xattr
block gets inserted into the cache even if it later turns out to be
corrupted. The attached patch reintroduces the sanity check, and has a
few other cosmetical-only changes.
Andrew, do you want to add this to -mm?
Cheers,
--
Andreas Gruenbacher <[email protected]>
SUSE Labs, SUSE LINUX AG
On Thu, 23 Sep 2004, Andreas Gruenbacher wrote:
> There is one minor issue in the ext[23]_xattr_list changes: The xattr
> block gets inserted into the cache even if it later turns out to be
> corrupted. The attached patch reintroduces the sanity check, and has a
> few other cosmetical-only changes.
>
> Andrew, do you want to add this to -mm?
These 'cosmetical-only' changes break listxattr on ext3 and ext2. Andrew,
please drop this patch.
Moving the mb cache insertion point can be done separately.
- James
--
James Morris
<[email protected]>
On Friday 24 September 2004 18:39, James Morris wrote:
> On Thu, 23 Sep 2004, Andreas Gruenbacher wrote:
> > There is one minor issue in the ext[23]_xattr_list changes: The xattr
> > block gets inserted into the cache even if it later turns out to be
> > corrupted. The attached patch reintroduces the sanity check, and has a
> > few other cosmetical-only changes.
> >
> > Andrew, do you want to add this to -mm?
>
> These 'cosmetical-only' changes break listxattr on ext3 and ext2. Andrew,
> please drop this patch.
Here is a fixed version. Feedback welcome.
Cheers,
--
Andreas Gruenbacher <[email protected]>
SUSE Labs, SUSE LINUX AG
On Sat, 25 Sep 2004, Andreas Gruenbacher wrote:
> Here is a fixed version. Feedback welcome.
Looks fine to me.
- James
--
James Morris
<[email protected]>