2004-10-12 00:41:22

by Blaisorblade

[permalink] [raw]
Subject: [patch 07/10] uml: kbuild - add even more cleaning


Remove one more symlink when doing

make mrproper ARCH=um

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[email protected]>
---

linux-2.6.9-current-paolo/arch/um/Makefile | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/um/Makefile~uml-kbuild-add-even-more-cleaning arch/um/Makefile
--- linux-2.6.9-current/arch/um/Makefile~uml-kbuild-add-even-more-cleaning 2004-10-12 01:08:08.925888512 +0200
+++ linux-2.6.9-current-paolo/arch/um/Makefile 2004-10-12 01:08:08.927888208 +0200
@@ -123,7 +123,7 @@ CLEAN_FILES += linux x.i gmon.out $(ARCH
$(GEN_HEADERS) $(ARCH_DIR)/include/skas_ptregs.h

MRPROPER_FILES += $(SYMLINK_HEADERS) $(ARCH_SYMLINKS) \
- $(addprefix $(ARCH_DIR)/kernel/,$(KERN_SYMLINKS))
+ $(addprefix $(ARCH_DIR)/kernel/,$(KERN_SYMLINKS)) $(ARCH_DIR)/os

archmrproper:
@:
_


2004-10-25 08:48:02

by Chris Wedgwood

[permalink] [raw]
Subject: Re: [patch 07/10] uml: kbuild - add even more cleaning

On Tue, Oct 12, 2004 at 02:17:59AM +0200, [email protected] wrote:

> MRPROPER_FILES += $(SYMLINK_HEADERS) $(ARCH_SYMLINKS) \
> - $(addprefix $(ARCH_DIR)/kernel/,$(KERN_SYMLINKS))
> + $(addprefix $(ARCH_DIR)/kernel/,$(KERN_SYMLINKS)) $(ARCH_DIR)/os

these sorts of rules don't work when doing "make O=build ARCH=um ..."

2004-10-25 20:24:20

by Blaisorblade

[permalink] [raw]
Subject: Re: [uml-devel] Re: [patch 07/10] uml: kbuild - add even more cleaning

On Monday 25 October 2004 10:43, Chris Wedgwood wrote:
> On Tue, Oct 12, 2004 at 02:17:59AM +0200, [email protected] wrote:
> > MRPROPER_FILES += $(SYMLINK_HEADERS) $(ARCH_SYMLINKS) \
> > - $(addprefix $(ARCH_DIR)/kernel/,$(KERN_SYMLINKS))
> > + $(addprefix $(ARCH_DIR)/kernel/,$(KERN_SYMLINKS)) $(ARCH_DIR)/os
>
> these sorts of rules don't work when doing "make O=build ARCH=um ..."
Yes, they do as much as they can. Kbuild cd's to the objtree before doing
anything. Specifying $(objtree) is not needed. Specifying $(obj) probably
does not even work in the ARCH Makefile.

That said, O=<whatever> is highly broken; it seems that Gerd Knorr was able to
build the tree with O=, but actually some files are still created in the
source tree, while they should not. This is a problem and would require
various changes.
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729