2004-09-12 09:38:58

by Tejun Heo

[permalink] [raw]
Subject: [PATCH] patsubstfor LOCALVERSION and -fno-omit-frame-pointer

(** Sorry, I'm resending this mail. I had written the subject in the
Reply-To field. **)

Hello, I'm attaching two patches for the top Makefile.

The first patch modifies LOCALVERSION definition such taht it uses
patsubst instead of subst to remove surrounding double quotes from
CONFIG_LOCALVERSION. This helps syntax-highlighting editors.

The second patch addes -fno-omit-frame-pointer to CFLAGS when
CONFIG_FRAME_POINTER is set. My gcc (gcc-3.3.4 Debian 1:3.3.4-11)
automatically turns on -fomit-frame-pointer when -O2 is specified and
thus breaks CONFIG_FRAME_POINTER option. I'm not sure if other
versions of gcc wouldn't choke with -fno-omit-frame-pointer. My 2.95
(2.95.4) seems to be OK though.

--
tejun

Attachments:
(No filename) (725.00 B)
 patsubst_localversion.patch (884.00 B)
 noomitframepointer.patch (883.00 B)
 Download all attachments

2004-10-16 22:01:35

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] patsubstfor LOCALVERSION and -fno-omit-frame-pointer

On Sun, Sep 12, 2004 at 06:36:35PM +0900, Tejun Heo wrote:
> (** Sorry, I'm resending this mail. I had written the subject in the
> Reply-To field. **)
>
> Hello, I'm attaching two patches for the top Makefile.
>
> The first patch modifies LOCALVERSION definition such taht it uses
> patsubst instead of subst to remove surrounding double quotes from
> CONFIG_LOCALVERSION. This helps syntax-highlighting editors.
>
> The second patch addes -fno-omit-frame-pointer to CFLAGS when
> CONFIG_FRAME_POINTER is set. My gcc (gcc-3.3.4 Debian 1:3.3.4-11)
> automatically turns on -fomit-frame-pointer when -O2 is specified and
> thus breaks CONFIG_FRAME_POINTER option. I'm not sure if other
> versions of gcc wouldn't choke with -fno-omit-frame-pointer. My 2.95
> (2.95.4) seems to be OK though.

Applied both.
Next time please send a single patch/mail.

Sam