2004-10-20 02:09:53

by Brian Gerst

[permalink] [raw]
Subject: [PATCH] Remove last reference to LDFLAGS_BLOB

diff -urN linux-2.6.9-bk/arch/m32r/Makefile linux/arch/m32r/Makefile
--- linux-2.6.9-bk/arch/m32r/Makefile 2004-10-18 20:34:14.000000000 -0400
+++ linux/arch/m32r/Makefile 2004-10-19 17:40:55.614157644 -0400
@@ -5,7 +5,6 @@
LDFLAGS :=
OBJCOPYFLAGS := -O binary -R .note -R .comment -S
LDFLAGS_vmlinux := -e startup_32
-LDFLAGS_BLOB := --format binary --oformat elf32-m32r

CFLAGS += -pipe -fno-schedule-insns
CFLAGS_KERNEL += -mmodel=medium
diff -urN linux-2.6.9-bk/usr/initramfs_data.S linux/usr/initramfs_data.S
--- linux-2.6.9-bk/usr/initramfs_data.S 2003-12-17 21:59:42.000000000 -0500
+++ linux/usr/initramfs_data.S 2004-10-19 17:41:16.191659582 -0400
@@ -1,28 +1,6 @@
/*
initramfs_data includes the compressed binary that is the
filesystem used for early user space.
- Note: Older versions of "as" (prior to binutils 2.11.90.0.23
- released on 2001-07-14) dit not support .incbin.
- If you are forced to use older binutils than that then the
- following trick can be applied to create the resulting binary:
-
-
- ld -m elf_i386 --format binary --oformat elf32-i386 -r \
- -T initramfs_data.scr initramfs_data.cpio.gz -o initramfs_data.o
- ld -m elf_i386 -r -o built-in.o initramfs_data.o
-
- initramfs_data.scr looks like this:
-SECTIONS
-{
- .init.ramfs : { *(.data) }
-}
-
- The above example is for i386 - the parameters vary from architectures.
- Eventually look up LDFLAGS_BLOB in an older version of the
- arch/$(ARCH)/Makefile to see the flags used before .incbin was introduced.
-
- Using .incbin has the advantage over ld that the correct flags are set
- in the ELF header, as required by certain architectures.
*/

.section .init.ramfs,"a"


Attachments:
ldflags_blob (1.66 kB)

2004-10-20 08:24:47

by Russell King

[permalink] [raw]
Subject: Re: [PATCH] Remove last reference to LDFLAGS_BLOB

On Tue, Oct 19, 2004 at 10:01:06PM -0400, Brian Gerst wrote:
> Nothing uses LDFLAGS_BLOB anymore, now that the arm binutils are fixed.

No it hasn't. We still have problems with ARM binutils. As I said
at the time, forcing us to upgrade _will_ cause major problems.

Essentially, all ARM binutils post 2.11.90 to date remain broken in
one way or another.

I should've been stronger to veto the obsolescence of 2.11.90 for
kernel building.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core

2004-10-21 14:14:08

by Marcelo Tosatti

[permalink] [raw]
Subject: Re: [PATCH] Remove last reference to LDFLAGS_BLOB


No, do not remove that initramfs_data.S section!

People with older binutils (like me) rely on it.

Make it obsolete on 2.7.x.

On Tue, Oct 19, 2004 at 10:01:06PM -0400, Brian Gerst wrote:
> Nothing uses LDFLAGS_BLOB anymore, now that the arm binutils are fixed.
>
> --
> Brian Gerst

> diff -urN linux-2.6.9-bk/arch/m32r/Makefile linux/arch/m32r/Makefile
> --- linux-2.6.9-bk/arch/m32r/Makefile 2004-10-18 20:34:14.000000000 -0400
> +++ linux/arch/m32r/Makefile 2004-10-19 17:40:55.614157644 -0400
> @@ -5,7 +5,6 @@
> LDFLAGS :=
> OBJCOPYFLAGS := -O binary -R .note -R .comment -S
> LDFLAGS_vmlinux := -e startup_32
> -LDFLAGS_BLOB := --format binary --oformat elf32-m32r
>
> CFLAGS += -pipe -fno-schedule-insns
> CFLAGS_KERNEL += -mmodel=medium
> diff -urN linux-2.6.9-bk/usr/initramfs_data.S linux/usr/initramfs_data.S
> --- linux-2.6.9-bk/usr/initramfs_data.S 2003-12-17 21:59:42.000000000 -0500
> +++ linux/usr/initramfs_data.S 2004-10-19 17:41:16.191659582 -0400
> @@ -1,28 +1,6 @@
> /*
> initramfs_data includes the compressed binary that is the
> filesystem used for early user space.
> - Note: Older versions of "as" (prior to binutils 2.11.90.0.23
> - released on 2001-07-14) dit not support .incbin.
> - If you are forced to use older binutils than that then the
> - following trick can be applied to create the resulting binary:
> -
> -
> - ld -m elf_i386 --format binary --oformat elf32-i386 -r \
> - -T initramfs_data.scr initramfs_data.cpio.gz -o initramfs_data.o
> - ld -m elf_i386 -r -o built-in.o initramfs_data.o
> -
> - initramfs_data.scr looks like this:
> -SECTIONS
> -{
> - .init.ramfs : { *(.data) }
> -}
> -
> - The above example is for i386 - the parameters vary from architectures.
> - Eventually look up LDFLAGS_BLOB in an older version of the
> - arch/$(ARCH)/Makefile to see the flags used before .incbin was introduced.
> -
> - Using .incbin has the advantage over ld that the correct flags are set
> - in the ELF header, as required by certain architectures.
> */
>
> .section .init.ramfs,"a"

2004-10-30 21:29:52

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] Remove last reference to LDFLAGS_BLOB

On Wed, Oct 20, 2004 at 03:59:27PM -0200, Marcelo Tosatti wrote:
>
> No, do not remove that initramfs_data.S section!

It's in a comment section??

Anyway for now I only removed the assignment in m32r Makefile.

Sam