2004-10-27 07:09:14

by Dmitry Torokhov

Subject: Problem with module parameters and sysfs

Hi,

It seems that the following patch

http://linux.bkbits.net:8080/linux-2.5/diffs/kernel/params.c%401.12?nav=index.html|ChangeSet@-3d|[email protected]

broke module parameters in sysfs for the case when driver is built
as a module:

[root@core dtor]# ls -la /sys/module/i8042/
total 0
drwxr-xr-x 3 root root 0 Oct 26 19:20 .
drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
drwxr-xr-x 2 root root 0 Oct 26 19:20 parameters

[root@core dtor]# ls -la /sys/module/psmouse/
total 0
drwxr-xr-x 3 root root 0 Oct 27 00:21 .
drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
-r--r--r-- 1 root root 4096 Oct 27 00:21 refcnt
drwxr-xr-x 2 root root 0 Oct 27 00:21 sections

psmouse is built as a module while i8042 is compiled in.

--
Dmitry

2004-10-27 09:01:24

by Dominik Brodowski

Subject: Re: Problem with module parameters and sysfs

On Wed, Oct 27, 2004 at 01:43:54AM -0500, Dmitry Torokhov wrote:
> Hi,
>
> It seems that the following patch
>
> http://linux.bkbits.net:8080/linux-2.5/diffs/kernel/params.c%401.12?nav=index.html|ChangeSet@-3d|[email protected]
>
> broke module parameters in sysfs for the case when driver is built
> as a module:
>
> [root@core dtor]# ls -la /sys/module/i8042/
> total 0
> drwxr-xr-x 3 root root 0 Oct 26 19:20 .
> drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
> drwxr-xr-x 2 root root 0 Oct 26 19:20 parameters
>
> [root@core dtor]# ls -la /sys/module/psmouse/
> total 0
> drwxr-xr-x 3 root root 0 Oct 27 00:21 .
> drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
> -r--r--r-- 1 root root 4096 Oct 27 00:21 refcnt
> drwxr-xr-x 2 root root 0 Oct 27 00:21 sections
>
> psmouse is built as a module while i8042 is compiled in.

All module_params I can see in psmouse have permission "0", so they don't
need to be exported in sysfs. Or am I missing something here?

Thanks,
Dominik

2004-10-27 13:28:26

by Dmitry Torokhov

Subject: Re: Problem with module parameters and sysfs

On Wednesday 27 October 2004 03:58 am, Dominik Brodowski wrote:
> On Wed, Oct 27, 2004 at 01:43:54AM -0500, Dmitry Torokhov wrote:
> > total 0
> > drwxr-xr-x 3 root root 0 Oct 27 00:21 .
> > drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
> > -r--r--r-- 1 root root 4096 Oct 27 00:21 refcnt
> > drwxr-xr-x 2 root root 0 Oct 27 00:21 sections
> >
> > psmouse is built as a module while i8042 is compiled in.
>
> All module_params I can see in psmouse have permission "0", so they don't
> need to be exported in sysfs. Or am I missing something here?
>

Ahem... Hand me that paper bag please...

Sorry for the noise, I did not find the params directory and assumed that
something went wrong without even thinking about permissions.

--
Dmitry