2004-10-29 22:46:57

by Jesse Barnes

[permalink] [raw]
Subject: [PATCH] deviceiobook.tmpl update

Greg and Grant, how does this small update look?

Thanks,
Jesse


Attachments:
(No filename) (64.00 B)
deviceiobook-update.patch (4.04 kB)
Download all attachments

2004-10-29 22:52:22

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH] deviceiobook.tmpl update

On Fri, Oct 29, 2004 at 03:41:49PM -0700, Jesse Barnes wrote:
> Greg and Grant, how does this small update look?

looks good to me.

thanks,
grant

>
> Thanks,
> Jesse

> ===== Documentation/DocBook/deviceiobook.tmpl 1.5 vs edited =====
> --- 1.5/Documentation/DocBook/deviceiobook.tmpl 2004-10-25 13:06:49 -07:00
> +++ edited/Documentation/DocBook/deviceiobook.tmpl 2004-10-29 15:38:01 -07:00
> @@ -195,7 +195,12 @@
> be strongly ordered coming from different CPUs. Thus it's important
> to properly protect parts of your driver that do memory-mapped writes
> with locks and use the <function>mmiowb</function> to make sure they
> - arrive in the order intended.
> + arrive in the order intended. Issuing a regular <function>readX
> + </function> will also ensure write ordering, but should only be used
> + when the driver has to be sure that the write has actually arrived
> + at the device (not that it's simply ordered with respect to other
> + writes), since a full <function>readX</function> is a relatively
> + expensive operation.
> </para>
...

2004-10-31 00:47:41

by Greg Banks

[permalink] [raw]
Subject: Re: [PATCH] deviceiobook.tmpl update

On Fri, Oct 29, 2004 at 03:41:49PM -0700, Jesse Barnes wrote:
> Greg and Grant, how does this small update look?
>
> Thanks,
> Jesse

Fine.

Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.