2004-11-02 23:37:36

by Jan Kasprzak

Subject: [PATCH] Minor fix of RCU documentation

Hello, all!

the attached patch fixes an incorrect example in Documentation/RCU/listRCU.txt
- the "original" lock-based code should not call RCU functions, of course.

-Yenya

Signed-Off-By: Jan "Yenya" Kasprzak <[email protected]>

--- linux-2.6.9/Documentation/RCU/listRCU.txt.orig 2004-10-18 23:53:44.000000000 +0200
+++ linux-2.6.9/Documentation/RCU/listRCU.txt 2004-10-30 14:49:42.706526360 +0200
@@ -82,7 +82,7 @@
list_for_each_entry(e, list, list) {
if (!audit_compare_rule(rule, &e->rule)) {
list_del(&e->list);
- call_rcu(&e->rcu, audit_free_rule, e);
+ write_unlock(&auditsc_lock);
return 0;
}
}

--
| Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/ Czech Linux Homepage: http://www.linux.cz/ |
> Whatever the Java applications and desktop dances may lead to, Unix will <
> still be pushing the packets around for a quite a while. --Rob Pike <

2004-11-03 19:09:28

by Paul E. McKenney

Subject: Re: [PATCH] Minor fix of RCU documentation

Good catch! Andrew, please apply.

Thanx, Paul

Acked-by: <[email protected]>

On Wed, Nov 03, 2004 at 12:23:18AM +0100, Jan Kasprzak wrote:
> Hello, all!
>
> the attached patch fixes an incorrect example in Documentation/RCU/listRCU.txt
> - the "original" lock-based code should not call RCU functions, of course.
>
> -Yenya
>
> Signed-Off-By: Jan "Yenya" Kasprzak <[email protected]>
>
> --- linux-2.6.9/Documentation/RCU/listRCU.txt.orig 2004-10-18 23:53:44.000000000 +0200
> +++ linux-2.6.9/Documentation/RCU/listRCU.txt 2004-10-30 14:49:42.706526360 +0200
> @@ -82,7 +82,7 @@
> list_for_each_entry(e, list, list) {
> if (!audit_compare_rule(rule, &e->rule)) {
> list_del(&e->list);
> - call_rcu(&e->rcu, audit_free_rule, e);
> + write_unlock(&auditsc_lock);
> return 0;
> }
> }
>
> --
> | Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> |
> | GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
> | http://www.fi.muni.cz/~kas/ Czech Linux Homepage: http://www.linux.cz/ |
> > Whatever the Java applications and desktop dances may lead to, Unix will <
> > still be pushing the packets around for a quite a while. --Rob Pike <
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>