2004-11-07 00:53:36

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] fs/coda/psdev.c shouldn't include lp.h


I don't see any reason why fs/coda/psdev.c includes lp.h


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.10-rc1-mm3-full/fs/coda/psdev.c.old 2004-11-07 01:31:11.000000000 +0100
+++ linux-2.6.10-rc1-mm3-full/fs/coda/psdev.c 2004-11-07 01:31:16.000000000 +0100
@@ -22,7 +22,6 @@
#include <linux/kernel.h>
#include <linux/major.h>
#include <linux/time.h>
-#include <linux/lp.h>
#include <linux/slab.h>
#include <linux/ioport.h>
#include <linux/fcntl.h>


2004-11-07 18:37:11

by Jan Harkes

[permalink] [raw]
Subject: Re: [2.6 patch] fs/coda/psdev.c shouldn't include lp.h

On Sun, Nov 07, 2004 at 01:52:58AM +0100, Adrian Bunk wrote:
> I don't see any reason why fs/coda/psdev.c includes lp.h

Agreed, my guess is that many of the includes were inherited from
some template and aren't actually necessary.

Jan