2004-11-09 20:35:11

by Anton Blanchard

[permalink] [raw]
Subject: [PATCH] ppc64: Bump MAX_HWIFS in IDE code


When fully configured, some POWER5 boxes can have much more than 4 IDE
interfaces. Increase the limit to reflect this.

Signed-off-by: Anton Blanchard <[email protected]>

diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h
--- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500
+++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500
@@ -19,7 +19,7 @@
#ifdef __KERNEL__

#ifndef MAX_HWIFS
-# define MAX_HWIFS 4
+# define MAX_HWIFS 16
#endif

#define IDE_ARCH_OBSOLETE_INIT
_


2004-11-09 20:51:05

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code

Anton Blanchard <[email protected]> wrote:
>
>
> When fully configured, some POWER5 boxes can have much more than 4 IDE
> interfaces. Increase the limit to reflect this.
>
> Signed-off-by: Anton Blanchard <[email protected]>
>
> diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h
> --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500
> +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500
> @@ -19,7 +19,7 @@
> #ifdef __KERNEL__
>
> #ifndef MAX_HWIFS
> -# define MAX_HWIFS 4
> +# define MAX_HWIFS 16
> #endif

hrmph. That costs 50kbytes, excluding ide-tape. It's worth a config
variable, I think.

2004-11-09 21:12:56

by Chris Wedgwood

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code

On Tue, Nov 09, 2004 at 12:55:07PM -0800, Andrew Morton wrote:

> hrmph. That costs 50kbytes, excluding ide-tape. It's worth a
> config variable, I think.

this come up from time to time, and i wonder why it can't be dynamic?

2004-11-09 21:26:14

by Anton Blanchard

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code


> > diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h
> > --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500
> > +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500
> > @@ -19,7 +19,7 @@
> > #ifdef __KERNEL__
> >
> > #ifndef MAX_HWIFS
> > -# define MAX_HWIFS 4
> > +# define MAX_HWIFS 16
> > #endif
>
> hrmph. That costs 50kbytes, excluding ide-tape. It's worth a config
> variable, I think.

Ouch. BTW i386 has it set to 10, it should be looked at as well.

Anton

2004-11-09 21:26:21

by Anton Blanchard

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code


> this come up from time to time, and i wonder why it can't be dynamic?

Agreed, that would be the best solution.

Anton

2004-11-09 21:37:17

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code

Anton Blanchard <[email protected]> wrote:
>
>
> > > diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h
> > > --- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500
> > > +++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500
> > > @@ -19,7 +19,7 @@
> > > #ifdef __KERNEL__
> > >
> > > #ifndef MAX_HWIFS
> > > -# define MAX_HWIFS 4
> > > +# define MAX_HWIFS 16
> > > #endif
> >
> > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a config
> > variable, I think.
>
> Ouch. BTW i386 has it set to 10, it should be looked at as well.
>

Oh, I failed to notice that it was a ppc64-specific header file. You can
afford 50k ;)

2004-11-09 22:14:55

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code

On Tue, 2004-11-09 at 13:12 -0800, Chris Wedgwood wrote:
> On Tue, Nov 09, 2004 at 12:55:07PM -0800, Andrew Morton wrote:
>
> > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a
> > config variable, I think.
>
> this come up from time to time, and i wonder why it can't be dynamic?

Good question :) I suppose Bart has that on his todolist, but it will
require some work on the IDE layer, which only few people can do without
breaking it all :)

Ben.


Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code

Anton, IDE driver is limited to 10 major numbers anyway
so please just use 10 for now...

On Wed, 10 Nov 2004 09:12:45 +1100, Benjamin Herrenschmidt
<[email protected]> wrote:
> On Tue, 2004-11-09 at 13:12 -0800, Chris Wedgwood wrote:
> > On Tue, Nov 09, 2004 at 12:55:07PM -0800, Andrew Morton wrote:
> >
> > > hrmph. That costs 50kbytes, excluding ide-tape. It's worth a
> > > config variable, I think.
> >
> > this come up from time to time, and i wonder why it can't be dynamic?
>
> Good question :) I suppose Bart has that on his todolist, but it will
> require some work on the IDE layer, which only few people can do without
> breaking it all :)

Yes I'm working on it and I will need some help with fixing PPC drivers. :)

2004-11-10 20:35:26

by Anton Blanchard

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code


> Anton, IDE driver is limited to 10 major numbers anyway
> so please just use 10 for now...

Thanks Bart, will do.

Anton

2004-11-10 20:48:03

by Anton Blanchard

[permalink] [raw]
Subject: Re: [PATCH] ppc64: Bump MAX_HWIFS in IDE code


When fully configured, some POWER5 boxes can have much more than 4 IDE
interfaces. Increase the limit to reflect this.

Signed-off-by: Anton Blanchard <[email protected]>

diff -puN include/asm-ppc64/ide.h~bump_ide_hwifs include/asm-ppc64/ide.h
--- gr_work/include/asm-ppc64/ide.h~bump_ide_hwifs 2004-08-25 08:11:54.357759525 -0500
+++ gr_work-anton/include/asm-ppc64/ide.h 2004-08-25 08:11:54.366758100 -0500
@@ -19,7 +19,7 @@
#ifdef __KERNEL__

#ifndef MAX_HWIFS
-# define MAX_HWIFS 4
+# define MAX_HWIFS 10
#endif

#define IDE_ARCH_OBSOLETE_INIT
_