2004-10-30 15:50:07

by Malte Schröder

[permalink] [raw]
Subject: [PATCH] WOL for sis900

Hello,
I have applied the patch from http://lkml.org/lkml/2003/7/16/88 manually
to 2.6.7 (also works on 2.6.{8,9}) and have been using it since then.
Attached is a diff against 2.6.9.

Greets
--
---------------------------------------
Malte Schr?der
[email protected]
ICQ# 68121508
---------------------------------------


Attachments:
sis900_wol.diff (2.66 kB)
signature.asc (256.00 B)
OpenPGP digital signature
Download all attachments

2004-10-30 16:18:34

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] WOL for sis900

Malte Schr?der wrote:
> Hello,
> I have applied the patch from http://lkml.org/lkml/2003/7/16/88 manually
> to 2.6.7 (also works on 2.6.{8,9}) and have been using it since then.
> Attached is a diff against 2.6.9.

Two comments:

1) Please include a signed-off-by line, as per

http://linux.yyz.us/patch-format.html
and
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

2) Please use ethtool to enable/disable WOL. No need for a module option.

2004-11-10 03:34:47

by Rusty Russell

[permalink] [raw]
Subject: Re: [PATCH] WOL for sis900

On Sat, 2004-10-30 at 17:43 +0200, Malte Schr?der wrote:
> Hello,
> I have applied the patch from http://lkml.org/lkml/2003/7/16/88 manually
> to 2.6.7 (also works on 2.6.{8,9}) and have been using it since then.
> Attached is a diff against 2.6.9.

Want to change the MODULE_PARM to new-style module_param() calls, too?

Thanks,
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman

2004-11-10 05:21:47

by Malte Schröder

[permalink] [raw]
Subject: Re: [PATCH] WOL for sis900

Rusty Russell wrote:
> On Sat, 2004-10-30 at 17:43 +0200, Malte Schr?der wrote:
>
>>Hello,
>>I have applied the patch from http://lkml.org/lkml/2003/7/16/88 manually
>>to 2.6.7 (also works on 2.6.{8,9}) and have been using it since then.
>>Attached is a diff against 2.6.9.
>
>
> Want to change the MODULE_PARM to new-style module_param() calls, too?

Since I don't exactly know what this means and currently don't have the
time to find out I don't think so.
And if WoL should be done using ethtool, my patch should be ignored and
the one of Daniele Venzano (posted to [email protected]) should be
considered.

(Will gather some more background information before posting a patch
next time ;) )

Greets :)
>
> Thanks,
> Rusty.


--
---------------------------------------
Malte Schr?der
[email protected]
ICQ# 68121508
---------------------------------------


Attachments:
signature.asc (256.00 B)
OpenPGP digital signature

2004-11-10 20:44:16

by Daniele Venzano

[permalink] [raw]
Subject: Re: [PATCH] WOL for sis900

On Wed, Nov 10, 2004 at 01:58:52PM +1100, Rusty Russell wrote:
> On Sat, 2004-10-30 at 17:43 +0200, Malte Schr?der wrote:
> > Hello,
> > I have applied the patch from http://lkml.org/lkml/2003/7/16/88 manually
> > to 2.6.7 (also works on 2.6.{8,9}) and have been using it since then.
> > Attached is a diff against 2.6.9.
>
> Want to change the MODULE_PARM to new-style module_param() calls, too?

Just added to the TODO list ;-)
I'm acting as maintainer for the sis900 driver and the list of the TODO
os growing at an awesome speed.

What I'm really lacking is some piece of technical documentation for the
chip. The WoL support depends on this, because I don't know how to check
for the hardware support for it.
For now I'll make available my patch on the sis900 page[1] that uses
ethtool and seems to work.

[1] http://teg.homeunix.org/sis900.html

--
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org

2004-11-10 21:27:00

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] WOL for sis900

Daniele Venzano wrote:
> What I'm really lacking is some piece of technical documentation for the
> chip. The WoL support depends on this, because I don't know how to check
> for the hardware support for it.

The sis900 hardware is based on the NatSemi register layout:
http://gkernel.sourceforge.net/specs/national_semi/DP83815.pdf.bz2