2004-11-18 12:39:32

by Andrew Walrond

Subject: [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)

Fix typo introduced during changes to use NV_ macros,
which caused screen corruption when using rivafb

signed-off-by: Andrew Walrond <[email protected]>


diff -Nru a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
--- a/drivers/video/riva/riva_hw.c 2004-11-18 12:32:15 +00:00
+++ b/drivers/video/riva/riva_hw.c 2004-11-18 12:32:15 +00:00
@@ -1556,7 +1556,7 @@
NV_WR32(chip->PGRAPH, 0x0000085C, state->pitch3);
NV_WR32(chip->PGRAPH, 0x00000860, state->pitch3);
NV_WR32(chip->PGRAPH, 0x00000864, state->pitch3);
- NV_WR32(chip->PGRAPH, 0x000009A, NV_RD32(chip->PFB, 0x00000200));
+ NV_WR32(chip->PGRAPH, 0x000009A4, NV_RD32(chip->PFB, 0x00000200));
NV_WR32(chip->PGRAPH, 0x000009A8, NV_RD32(chip->PFB, 0x00000204));
}
if(chip->twoHeads) {

2004-11-18 12:56:03

by Andrew Walrond

Subject: Re: [Linux-fbdev-devel] [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)

Fixing this typo cures the screen corruption I was seeing on both 32 and 64bit
x86_64 kernels.

Thanks for the help tracking this down. Please apply!

Andrew Walrond

2004-11-18 23:10:15

by Antonino A. Daplas

Subject: Re: [Linux-fbdev-devel] [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)

On Thursday 18 November 2004 20:55, Andrew Walrond wrote:
> Fixing this typo cures the screen corruption I was seeing on both 32 and
> 64bit x86_64 kernels.
>
> Thanks for the help tracking this down. Please apply!
>

No, thank _you_ for the help tracking this down :-)

Tony