2004-11-18 16:45:21

by Daniel Drake

[permalink] [raw]
Subject: [PATCH] Permit LOG_SENSE and LOG_SELECT in SG_IO command table

--- linux/drivers/block/scsi_ioctl.c.orig 2004-11-18 18:18:49.666216472 +0000
+++ linux/drivers/block/scsi_ioctl.c 2004-11-18 18:22:50.271638888 +0000
@@ -127,6 +127,7 @@ static int verify_command(struct file *f
safe_for_read(INQUIRY),
safe_for_read(MODE_SENSE),
safe_for_read(MODE_SENSE_10),
+ safe_for_read(LOG_SENSE),
safe_for_read(START_STOP),
safe_for_read(GPCMD_VERIFY_10),
safe_for_read(VERIFY_16),
@@ -169,6 +170,7 @@ static int verify_command(struct file *f
safe_for_write(ERASE),
safe_for_write(GPCMD_MODE_SELECT_10),
safe_for_write(MODE_SELECT),
+ safe_for_write(LOG_SELECT),
safe_for_write(GPCMD_BLANK),
safe_for_write(GPCMD_CLOSE_TRACK),
safe_for_write(GPCMD_FLUSH_CACHE),


Attachments:
scsi_ioctl-permit-log-sense-select.patch (724.00 B)

2004-11-18 18:44:16

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] Permit LOG_SENSE and LOG_SELECT in SG_IO command table

On Thu, Nov 18 2004, Daniel Drake wrote:
> Hi,
>
> This patch adds LOG_SENSE as a read-ok command. cdrecord-prodvd uses this.
> I also added LOG_SELECT as write-ok as this seems to fit in as well.
>
> Signed-off-by: Daniel Drake <[email protected]>

Acked-by: Jens Axboe <[email protected]>

> --- linux/drivers/block/scsi_ioctl.c.orig 2004-11-18 18:18:49.666216472 +0000
> +++ linux/drivers/block/scsi_ioctl.c 2004-11-18 18:22:50.271638888 +0000
> @@ -127,6 +127,7 @@ static int verify_command(struct file *f
> safe_for_read(INQUIRY),
> safe_for_read(MODE_SENSE),
> safe_for_read(MODE_SENSE_10),
> + safe_for_read(LOG_SENSE),
> safe_for_read(START_STOP),
> safe_for_read(GPCMD_VERIFY_10),
> safe_for_read(VERIFY_16),
> @@ -169,6 +170,7 @@ static int verify_command(struct file *f
> safe_for_write(ERASE),
> safe_for_write(GPCMD_MODE_SELECT_10),
> safe_for_write(MODE_SELECT),
> + safe_for_write(LOG_SELECT),
> safe_for_write(GPCMD_BLANK),
> safe_for_write(GPCMD_CLOSE_TRACK),
> safe_for_write(GPCMD_FLUSH_CACHE),


--
Jens Axboe