2004-11-19 22:20:10

by Prasanna Meda

[permalink] [raw]
Subject: [ proc patch ] cmdline missing mmput


Fix the mmput bug introduced while fixing cmdline race.

Signed-off-by: Prasanna Meda <[email protected]>


--- a/fs/proc/base.c Fri Nov 19 14:42:07 2004
+++ b/fs/proc/base.c Fri Nov 19 14:45:19 2004
@@ -342,7 +342,7 @@
if (!mm)
goto out;
if (!mm->arg_end)
- goto out; /* Shh! No looking before we're done */
+ goto out_mm; /* Shh! No looking before we're done */

len = mm->arg_end - mm->arg_start;

@@ -365,8 +365,8 @@
res = strnlen(buffer, res);
}
}
+out_mm:
mmput(mm);
-
out:
return res;
}