2004-10-28 23:16:31

by Adrian Bunk

Subject: [2.6 patch] pcmcia/yenta_socket.c: remove an unused function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unused function from
drivers/pcmcia/yenta_socket.c


diffstat output:
drivers/pcmcia/yenta_socket.c | 9 ---------
1 files changed, 9 deletions(-)


Signed-off-by: Adrian Bunk <[email protected]>

- --- linux-2.6.10-rc1-mm1-full/drivers/pcmcia/yenta_socket.c.old 2004-10-28 23:23:42.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/pcmcia/yenta_socket.c 2004-10-28 23:23:54.000000000 +0200
@@ -109,15 +109,6 @@
return val;
}

- -static inline u8 exca_readw(struct yenta_socket *socket, unsigned reg)
- -{
- - u16 val;
- - val = readb(socket->base + 0x800 + reg);
- - val |= readb(socket->base + 0x800 + reg + 1) << 8;
- - debug("%p %04x %04x\n", socket, reg, val);
- - return val;
- -}
- -
static inline void exca_writeb(struct yenta_socket *socket, unsigned reg, u8 val)
{
debug("%p %04x %02x\n", socket, reg, val);

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgX0WmfzqmE8StAARAn5EAKCM4SCL+XDYjmNZ4XGNYEbscJ1yLgCdHt/L
SuvjYnXEm4C3sU/lNWX6Zvs=
=Tthp
-----END PGP SIGNATURE-----

2004-10-29 00:32:55

by Adrian Bunk

Subject: [2.6 patch] pcmcia/yenta_socket.c: remove an unused function

[ this time without the problems due to a digital signature... ]

The patch below removes an unused function from
drivers/pcmcia/yenta_socket.c


diffstat output:
drivers/pcmcia/yenta_socket.c | 9 ---------
1 files changed, 9 deletions(-)


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.10-rc1-mm1-full/drivers/pcmcia/yenta_socket.c.old 2004-10-28 23:23:42.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/pcmcia/yenta_socket.c 2004-10-28 23:23:54.000000000 +0200
@@ -109,15 +109,6 @@
return val;
}

-static inline u8 exca_readw(struct yenta_socket *socket, unsigned reg)
-{
- u16 val;
- val = readb(socket->base + 0x800 + reg);
- val |= readb(socket->base + 0x800 + reg + 1) << 8;
- debug("%p %04x %04x\n", socket, reg, val);
- return val;
-}
-
static inline void exca_writeb(struct yenta_socket *socket, unsigned reg, u8 val)
{
debug("%p %04x %02x\n", socket, reg, val);

2004-11-20 09:37:28

by Russell King

Subject: Re: [2.6 patch] pcmcia/yenta_socket.c: remove an unused function

On Fri, Oct 29, 2004 at 02:25:09AM +0200, Adrian Bunk wrote:
> The patch below removes an unused function from
> drivers/pcmcia/yenta_socket.c

I'd rather not remove this function - it's part of a logical set of IO
primitives for this device.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core