2004-11-13 23:43:07

by Jan Dittmer

Subject: [PATCH] sr module_param conversion

module_param conversion for SCSI cdrom driver

Signed-off-by: Jan Dittmer <[email protected]>


diff -Nru a/drivers/scsi/sr.c b/drivers/scsi/sr.c
--- a/drivers/scsi/sr.c 2004-11-14 00:36:56 +01:00
+++ b/drivers/scsi/sr.c 2004-11-14 00:36:56 +01:00
@@ -59,9 +59,6 @@
#include "sr.h"


-MODULE_PARM(xa_test, "i"); /* see sr_ioctl.c */
-
-
#define SR_DISKS 256

#define MAX_RETRIES 3
diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
--- a/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
+++ b/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
@@ -29,6 +29,9 @@
* It is off by default and can be turned on with this module parameter */
static int xa_test = 0;

+module_param(xa_test, int, S_IRUGO | S_IWUSR);
+
+
#define IOCTL_RETRIES 3

/* ATAPI drives don't have a SCMD_PLAYAUDIO_TI command. When these drives

2004-11-21 11:13:06

by Rolf Eike Beer

Subject: Re: [PATCH] sr module_param conversion

Jan Dittmer wrote:
> module_param conversion for SCSI cdrom driver
>
> Signed-off-by: Jan Dittmer <[email protected]>

> diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
> --- a/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
> +++ b/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
> @@ -29,6 +29,9 @@
> * It is off by default and can be turned on with this module parameter */
> static int xa_test = 0;
>
> +module_param(xa_test, int, S_IRUGO | S_IWUSR);
> +
> +

I think it should be "bool" instead of "int". And one newline should be
enough for everyone.

You should CC [email protected] and James Bottomley
<[email protected]> to get this applied.

Eike