2005-01-04 14:53:20

by Liam Girdwood

[permalink] [raw]
Subject: [PATCH 1/2] AC97 plugin suspend/resume

This patch adds suspend and resume support to OSS AC97 plugins.

Changes :-

o added suspend/resume callbacks to struct ac97_driver
o added suspend/resume handlers to ac97_codec.c

Signed-off-by: Liam Girdwood <[email protected]>

Liam


Attachments:
ac97_codec_pm.diff (1.71 kB)

2005-01-04 15:19:27

by Russell King

[permalink] [raw]
Subject: Re: [PATCH 1/2] AC97 plugin suspend/resume

On Tue, Jan 04, 2005 at 02:50:43PM +0000, Liam Girdwood wrote:
> This patch adds suspend and resume support to OSS AC97 plugins.
>
> Changes :-
>
> o added suspend/resume callbacks to struct ac97_driver
> o added suspend/resume handlers to ac97_codec.c
>
> Signed-off-by: Liam Girdwood <[email protected]>

Liam,

Please consider giving credit where credit is due. Thanks.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core

2005-01-04 15:56:07

by Liam Girdwood

[permalink] [raw]
Subject: Re: [PATCH 1/2] AC97 plugin suspend/resume

On Tue, 2005-01-04 at 15:19, Russell King wrote:
> Liam,
>
> Please consider giving credit where credit is due. Thanks.

Sorry Russell,

I had no idea who in the group had originally made the change since
yourself and Vince were accepting the kernel patches. I thought it would
be better to submit it signed rather than unsigned.

Please let me know who is responsible and if it's ok, I'll then
re-submit.

Best Regards

Liam

2005-01-04 16:12:56

by Russell King

[permalink] [raw]
Subject: Re: [PATCH 1/2] AC97 plugin suspend/resume

On Tue, Jan 04, 2005 at 03:55:48PM +0000, Liam Girdwood wrote:
> On Tue, 2005-01-04 at 15:19, Russell King wrote:
> > Liam,
> >
> > Please consider giving credit where credit is due. Thanks.
>
> Sorry Russell,
>
> I had no idea who in the group had originally made the change since
> yourself and Vince were accepting the kernel patches. I thought it would
> be better to submit it signed rather than unsigned.
>
> Please let me know who is responsible and if it's ok, I'll then
> re-submit.

Yours truely is responsible for this code change - it was committed
into "that" CVS tree with these comments originally:

Reference: 13-wm97xx/03-ac97-pm

- Add suspend/resume methods to the ac97 codec plugin driver structure.
- Add code to ac97_codec to allow these methods to be safely called for
the specified codec.
- Convert ac97_plugin_wm97xx to use these two pointers for its suspend
and resume hooks.
- Modify pxa-ac97 to call the new ac97_codec suspend/resume functions.

so what you have there is a cut down version of this patch.

If you want an archive of the cvs commit messages for "that" CVS tree,
I can throw you a copy.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core