2005-01-07 01:41:47

by Adrian Bunk

Subject: [2.6 patch] fs/hugetlbfs/inode.c: make 4 functions static

The patch below makes four needlessly global functions static.


diffstta output:
fs/hugetlbfs/inode.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.10-mm2-full/fs/hugetlbfs/inode.c.old 2005-01-07 00:54:42.000000000 +0100
+++ linux-2.6.10-mm2-full/fs/hugetlbfs/inode.c 2005-01-07 00:55:32.000000000 +0100
@@ -168,7 +168,7 @@
return -EINVAL;
}

-void huge_pagevec_release(struct pagevec *pvec)
+static void huge_pagevec_release(struct pagevec *pvec)
{
int i;

@@ -178,7 +178,7 @@
pagevec_reinit(pvec);
}

-void truncate_huge_page(struct page *page)
+static void truncate_huge_page(struct page *page)
{
clear_page_dirty(page);
ClearPageUptodate(page);
@@ -186,7 +186,7 @@
put_page(page);
}

-void truncate_hugepages(struct address_space *mapping, loff_t lstart)
+static void truncate_hugepages(struct address_space *mapping, loff_t lstart)
{
const pgoff_t start = lstart >> HPAGE_SHIFT;
struct pagevec pvec;
@@ -495,7 +495,7 @@
/*
* For direct-IO reads into hugetlb pages
*/
-int hugetlbfs_set_page_dirty(struct page *page)
+static int hugetlbfs_set_page_dirty(struct page *page)
{
return 0;
}

2005-01-07 01:41:46

by William Lee Irwin III

Subject: Re: [2.6 patch] fs/hugetlbfs/inode.c: make 4 functions static

On Fri, Jan 07, 2005 at 02:29:00AM +0100, Adrian Bunk wrote:
> The patch below makes four needlessly global functions static.
> diffstta output:
> fs/hugetlbfs/inode.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
> Signed-off-by: Adrian Bunk <[email protected]>

Acked-by: William Irwin <[email protected]>


-- wli