2005-01-10 19:35:42

by Domen Puncer

[permalink] [raw]
Subject: [patch 2/5] list_for_each_entry in fs/dcache.c




Hi.

First 2 are list_for_each_entry (thanks maks), second 2 list_for_each_safe.
Boot tested.

Signed-off-by: Domen Puncer <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>
Signed-off-by: Domen Puncer <[email protected]>
---


kj-domen/fs/dcache.c | 16 ++++------------
1 files changed, 4 insertions(+), 12 deletions(-)

diff -puN fs/dcache.c~list-for-each-fs_dcache fs/dcache.c
--- kj/fs/dcache.c~list-for-each-fs_dcache 2005-01-10 17:59:46.000000000 +0100
+++ kj-domen/fs/dcache.c 2005-01-10 17:59:46.000000000 +0100
@@ -334,12 +334,10 @@ struct dentry * d_find_alias(struct inod
*/
void d_prune_aliases(struct inode *inode)
{
- struct list_head *tmp, *head = &inode->i_dentry;
+ struct dentry *dentry;
restart:
spin_lock(&dcache_lock);
- tmp = head;
- while ((tmp = tmp->next) != head) {
- struct dentry *dentry = list_entry(tmp, struct dentry, d_alias);
+ list_for_each_entry(dentry, &inode->i_dentry, d_alias) {
if (!atomic_read(&dentry->d_count)) {
__dget_locked(dentry);
__d_drop(dentry);
@@ -457,10 +455,7 @@ void shrink_dcache_sb(struct super_block
* superblock to the most recent end of the unused list.
*/
spin_lock(&dcache_lock);
- next = dentry_unused.next;
- while (next != &dentry_unused) {
- tmp = next;
- next = tmp->next;
+ list_for_each_safe(tmp, next, &dentry_unused) {
dentry = list_entry(tmp, struct dentry, d_lru);
if (dentry->d_sb != sb)
continue;
@@ -472,10 +467,7 @@ void shrink_dcache_sb(struct super_block
* Pass two ... free the dentries for this superblock.
*/
repeat:
- next = dentry_unused.next;
- while (next != &dentry_unused) {
- tmp = next;
- next = tmp->next;
+ list_for_each_safe(tmp, next, &dentry_unused) {
dentry = list_entry(tmp, struct dentry, d_lru);
if (dentry->d_sb != sb)
continue;
_