2005-01-10 18:48:03

by Domen Puncer

Subject: [patch 1/1] list_for_each_entry: fs-dquot.c

Make code more readable with list_for_each_entry_safe.
(Didn't compile before, doesn't compile now)

Signed-off-by: Domen Puncer <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>
Signed-off-by: Domen Puncer <[email protected]>
---


kj-domen/fs/dquot.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)

diff -puN fs/dquot.c~list-for-each-entry-safe-fs_dquot fs/dquot.c
--- kj/fs/dquot.c~list-for-each-entry-safe-fs_dquot 2005-01-10 17:59:46.000000000 +0100
+++ kj-domen/fs/dquot.c 2005-01-10 17:59:46.000000000 +0100
@@ -406,13 +406,10 @@ out_dqlock:
* for this sb+type at all. */
static void invalidate_dquots(struct super_block *sb, int type)
{
- struct dquot *dquot;
- struct list_head *head;
+ struct dquot *dquot, *tmp;

spin_lock(&dq_list_lock);
- for (head = inuse_list.next; head != &inuse_list;) {
- dquot = list_entry(head, struct dquot, dq_inuse);
- head = head->next;
+ list_for_each_entry_safe(dquot, tmp, &inuse_list, dq_inuse) {
if (dquot->dq_sb != sb)
continue;
if (dquot->dq_type != type)
_

2005-01-11 14:36:53

by Jan Kara

Subject: Re: [patch 1/1] list_for_each_entry: fs-dquot.c

Hello,

> Make code more readable with list_for_each_entry_safe.
> (Didn't compile before, doesn't compile now)
What do you mean by "didn't compile before"? Which kernel have you
tried?

> Signed-off-by: Maximilian Attems <[email protected]>
> Signed-off-by: Domen Puncer <[email protected]>
> ---
>
>
> kj-domen/fs/dquot.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff -puN fs/dquot.c~list-for-each-entry-safe-fs_dquot fs/dquot.c
> --- kj/fs/dquot.c~list-for-each-entry-safe-fs_dquot 2005-01-10 17:59:46.000000000 +0100
> +++ kj-domen/fs/dquot.c 2005-01-10 17:59:46.000000000 +0100
> @@ -406,13 +406,10 @@ out_dqlock:
> * for this sb+type at all. */
> static void invalidate_dquots(struct super_block *sb, int type)
> {
> - struct dquot *dquot;
> - struct list_head *head;
> + struct dquot *dquot, *tmp;
>
> spin_lock(&dq_list_lock);
> - for (head = inuse_list.next; head != &inuse_list;) {
> - dquot = list_entry(head, struct dquot, dq_inuse);
> - head = head->next;
> + list_for_each_entry_safe(dquot, tmp, &inuse_list, dq_inuse) {
> if (dquot->dq_sb != sb)
> continue;
> if (dquot->dq_type != type)


Honza
--
Jan Kara <[email protected]>
SuSE CR Labs

2005-01-11 15:33:13

by Domen Puncer

Subject: Re: [patch 1/1] list_for_each_entry: fs-dquot.c

On 11/01/05 15:34 +0100, Jan Kara wrote:
> Hello,
>
> > Make code more readable with list_for_each_entry_safe.
> > (Didn't compile before, doesn't compile now)
> What do you mean by "didn't compile before"? Which kernel have you
> tried?

It seems like it was compile tested with quotas disabled.
It compiles fine when i enable quotas, duh.
Sorry.


Domen