Linux Kernel Mailing List wrote:
> ChangeSet 1.2334, 2005/01/11 09:21:40-08:00, [email protected]
>
> [PATCH] silence numerous size_t warnings in drivers/acpi/processor_idle.c
>
> Multiple format -related warnings arise from size_t issues. This patch
> peppers the seq_printf()'s with 'z' qualifiers and casts to silence them all.
Does this mean that ptrdiff_t type looks same as a size_t
to printk() & seq_printf() ?
> processor_idle.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
>
> diff -Nru a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> --- a/drivers/acpi/processor_idle.c 2005-01-11 11:17:04 -08:00
> +++ b/drivers/acpi/processor_idle.c 2005-01-11 11:17:04 -08:00
> @@ -838,12 +838,12 @@
> if (!pr)
> goto end;
>
> - seq_printf(seq, "active state: C%d\n"
> + seq_printf(seq, "active state: C%zd\n"
> "max_cstate: C%d\n"
> "bus master activity: %08x\n",
> pr->power.state ? pr->power.state - pr->power.states : 0,
> max_cstate,
> - pr->power.bm_activity);
> + (unsigned)pr->power.bm_activity);
>
> seq_puts(seq, "states:\n");
>
> @@ -872,14 +872,14 @@
> }
>
> if (pr->power.states[i].promotion.state)
> - seq_printf(seq, "promotion[C%d] ",
> + seq_printf(seq, "promotion[C%zd] ",
> (pr->power.states[i].promotion.state -
> pr->power.states));
> else
> seq_puts(seq, "promotion[--] ");
>
> if (pr->power.states[i].demotion.state)
> - seq_printf(seq, "demotion[C%d] ",
> + seq_printf(seq, "demotion[C%zd] ",
> (pr->power.states[i].demotion.state -
> pr->power.states));
> else
> -
--
~Randy
ChangeSet 1.2334, 2005/01/11 09:21:40-08:00, [email protected]
>> [PATCH] silence numerous size_t warnings in
>> drivers/acpi/processor_idle.c
>> Multiple format -related warnings arise from size_t issues. This
>> patch
>> peppers the seq_printf()'s with 'z' qualifiers and casts to silence
>> them all.
On Tue, Jan 11, 2005 at 12:27:24PM -0800, Randy.Dunlap wrote:
> Does this mean that ptrdiff_t type looks same as a size_t
> to printk() & seq_printf() ?
As far as I know this is the case. I have no specific opinion on this
being a better way to do it than something else.
-- wli