2005-01-11 23:24:13

by Domen Puncer

[permalink] [raw]
Subject: [patch 3/4] block/swim3: replace direct assignment with set_current_state()




Any comments would be appreciated.

Description: set_current_state() is used instead of direct assignment of
current->state.

Signed-off-by: Nishanth Aravamudan <[email protected]>
Signed-off-by: Maximilian Attems <[email protected]>
Signed-off-by: Domen Puncer <[email protected]>
---


kj-domen/drivers/block/swim3.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff -puN drivers/block/swim3.c~set_current_state-drivers_block_swim3 drivers/block/swim3.c
--- kj/drivers/block/swim3.c~set_current_state-drivers_block_swim3 2005-01-10 17:59:55.000000000 +0100
+++ kj-domen/drivers/block/swim3.c 2005-01-10 17:59:55.000000000 +0100
@@ -832,7 +832,7 @@ static int fd_eject(struct floppy_state
break;
}
swim3_select(fs, RELAX);
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
if (swim3_readbit(fs, DISK_IN) == 0)
break;
@@ -900,7 +900,7 @@ static int floppy_open(struct inode *ino
break;
}
swim3_select(fs, RELAX);
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
if (err == 0 && (swim3_readbit(fs, SEEK_COMPLETE) == 0
@@ -984,7 +984,7 @@ static int floppy_revalidate(struct gend
if (signal_pending(current))
break;
swim3_select(fs, RELAX);
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(1);
}
ret = swim3_readbit(fs, SEEK_COMPLETE) == 0
_