2005-01-13 20:43:12

by cruse

[permalink] [raw]
Subject: Re: Change i386 assembler/disassembler for SIB with INDEX==4


On Thu, 13 Jan 2005, "H. J. Lu" <[email protected]> wrote:
>
>
>
> Subject: Change i386 assembler/disassembler for SIB with INDEX==4
>
> I am proposing to change i386 assembler/disassembler for SIB with
> INDEX==4
>
> http://sources.redhat.com/bugzilla/show_bug.cgi?id=658
>
> It will change the assembler output for (%ebx,[1248]). I am not too
> worried about the disassembler output since assembler can't generate
> SIB with INDEX==4 directly today. Any comments?
>
>
> H.J.
>


This change would give programmers the freedom to write instruction-
syntax that the processor cannot actually execute, is that right?

Perhaps the downside to this would lie in the hours of debugging and
private research each programmer would then be faced with, trying to
figure out why " movl (%esi,2),%eax " wasn't doing what he/she had
intended, and which the assembler had dutifully accepted. --ABC




2005-01-13 22:53:07

by H. J. Lu

[permalink] [raw]
Subject: Re: Change i386 assembler/disassembler for SIB with INDEX==4

On Thu, Jan 13, 2005 at 12:33:28PM -0800, Allan B. Cruse wrote:
>
> On Thu, 13 Jan 2005, "H. J. Lu" <[email protected]> wrote:
> >
> >
> >
> > Subject: Change i386 assembler/disassembler for SIB with INDEX==4
> >
> > I am proposing to change i386 assembler/disassembler for SIB with
> > INDEX==4
> >
> > http://sources.redhat.com/bugzilla/show_bug.cgi?id=658
> >
> > It will change the assembler output for (%ebx,[1248]). I am not too
> > worried about the disassembler output since assembler can't generate
> > SIB with INDEX==4 directly today. Any comments?
> >
> >
> > H.J.
> >
>
>
> This change would give programmers the freedom to write instruction-
> syntax that the processor cannot actually execute, is that right?

No. Assemberl will turn "mov (%ebx,2),%eax" into "8b 04 63", which
is valid i386 machine code.

>
> Perhaps the downside to this would lie in the hours of debugging and
> private research each programmer would then be faced with, trying to
> figure out why " movl (%esi,2),%eax " wasn't doing what he/she had
> intended, and which the assembler had dutifully accepted. --ABC
>

What do you expect "movl (%esi,2),%eax" will do?


H.J.

2005-01-14 00:24:12

by Alan Modra

[permalink] [raw]
Subject: Re: Change i386 assembler/disassembler for SIB with INDEX==4

On Thu, Jan 13, 2005 at 02:46:01PM -0800, H. J. Lu wrote:
> On Thu, Jan 13, 2005 at 12:33:28PM -0800, Allan B. Cruse wrote:
> >
> > On Thu, 13 Jan 2005, "H. J. Lu" <[email protected]> wrote:
> > >
> > >
> > >
> > > Subject: Change i386 assembler/disassembler for SIB with INDEX==4
> > >
> > > I am proposing to change i386 assembler/disassembler for SIB with
> > > INDEX==4
> > >
> > > http://sources.redhat.com/bugzilla/show_bug.cgi?id=658
> > >
> > > It will change the assembler output for (%ebx,[1248]). I am not too
> > > worried about the disassembler output since assembler can't generate
> > > SIB with INDEX==4 directly today. Any comments?
> > >
> > >
> > > H.J.
> > >
> >
> >
> > This change would give programmers the freedom to write instruction-
> > syntax that the processor cannot actually execute, is that right?
>
> No. Assemberl will turn "mov (%ebx,2),%eax" into "8b 04 63", which
> is valid i386 machine code.

I don't see any particular need to support generation of this
instruction coding. Feeding the output of the disassembler back to the
assembler won't generate the same encodings for many instructions, eg.
there are two ways to encode mov %eax,%ebx (and some people even use
the two reg->reg move encodings to hide messages in code). Another
example is that the assembler chooses the smallest immediate or
displacement encoding.

> >
> > Perhaps the downside to this would lie in the hours of debugging and
> > private research each programmer would then be faced with, trying to
> > figure out why " movl (%esi,2),%eax " wasn't doing what he/she had
> > intended, and which the assembler had dutifully accepted. --ABC

Huh? The assembler will warn about this construct, and we certainly
should continue to warn, so that people who meant to write
"mov (,%esi,2),%eax" get a clue.

>
> What do you expect "movl (%esi,2),%eax" will do?
>
>
> H.J.

--
Alan Modra
IBM OzLabs - Linux Technology Centre