2005-01-14 01:18:14

by Andrea Arcangeli

[permalink] [raw]
Subject: lcall disappeared? kernel CVS destabilized?

I'm porting the seccomp patch to 2.6.10, do you have an idea where lcall
(i.e. call gates for binary compatibility with other OS) went? I can't
find it anywhere. Looks like it was dropped but I must be sure of that,
and especially I must be sure that you don't add it again without me
noticing that I had to patch it ;). Is lcall definitely dead code that I
can forget about or am I missing something? Thanks.

Kernel CVS is broken here, it doesn't even show me the changeset where
lcall disappeared, this returns nothing obvious:

cvsps -g -r v2_6_8 -f arch/i386/kernel/entry.S

If I use cvsps -x --bkcvs the changesets are screwed.

Note that the entry.S of the kernel CVS has not the lcall, it's
magically forgetting to show me a chageset, and I doubt cvsps is to
blame here, since it was working well for a long time before the thing
destabilized.

Can somebody confirm the kernel CVS is unstable or am I the only one
having deep troubles?


2005-01-14 01:33:06

by Andrew Morton

[permalink] [raw]
Subject: Re: lcall disappeared? kernel CVS destabilized?

Andrea Arcangeli <[email protected]> wrote:
>
> I'm porting the seccomp patch to 2.6.10, do you have an idea where lcall
> (i.e. call gates for binary compatibility with other OS) went?

Was removed on October 18.

http://linux.bkbits.net:8080/linux-2.5/diffs/arch/i386/kernel/[email protected]?nav=index.html|src/|src/arch|src/arch/i386|src/arch/i386/kernel|hist/arch/i386/kernel/entry.S

2005-01-14 01:37:13

by Andi Kleen

[permalink] [raw]
Subject: Re: lcall disappeared? kernel CVS destabilized?

Andrea Arcangeli <[email protected]> writes:

> I'm porting the seccomp patch to 2.6.10, do you have an idea where lcall
> (i.e. call gates for binary compatibility with other OS) went? I can't
> find it anywhere. Looks like it was dropped but I must be sure of that,
> and especially I must be sure that you don't add it again without me
> noticing that I had to patch it ;). Is lcall definitely dead code that I
> can forget about or am I missing something? Thanks.

hch removed it some time ago because nobody used it anymore (Linux ABI
is not supported on 2.6) and it showed some potential security issues

-Andi

2005-01-14 01:53:11

by Andrea Arcangeli

[permalink] [raw]
Subject: Re: lcall disappeared? kernel CVS destabilized?

On Thu, Jan 13, 2005 at 05:26:51PM -0800, Andrew Morton wrote:
> Andrea Arcangeli <[email protected]> wrote:
> >
> > I'm porting the seccomp patch to 2.6.10, do you have an idea where lcall
> > (i.e. call gates for binary compatibility with other OS) went?
>
> Was removed on October 18.
>
> http://linux.bkbits.net:8080/linux-2.5/diffs/arch/i386/kernel/[email protected]?nav=index.html|src/|src/arch|src/arch/i386|src/arch/i386/kernel|hist/arch/i386/kernel/entry.S

Ok, thanks to both for the confirmation ;).