2005-01-15 18:31:06

by Mikael Pettersson

[permalink] [raw]
Subject: Re: Screwy clock after apm suspend

On Tue, 11 Jan 2005 14:10:19 +0100, Pavel Machek wrote:
>> > Looking harder, in arch/i386/kernel/apm.c the system time is also
>> > saved and restored in a very similar way to timer_suspend/resume.
>> > Would this account for the time drift in APM mode? (sleep time being
>> > accounted for twice?)
>>
>> No, apm.c's update to xtime is absolute, just like time.c's.
>> Doing both is pointless but not harmful. (I've already tried
>> with apm.c's xtime update commented out, but the time-warp
>> bug remained.)
>>
>> My 0.02 SEK says it's the jiffies update that's broken.
>
>Okay, can you
>
>* kill jiffie update (x86-64, too)
>* remove apm.c variant
>* test it (or make someone test it) with apm?
>
>I now see the drift with acpi, too :-(. I can do the acpi testing...

I'm no longer seeing any time jumps after resumes with the
2.6.11-rc1 kernel. It looks like the wall_jiffies change in
time.c fixed the bug.

/Mikael


2005-01-16 19:52:23

by Alex Romosan

[permalink] [raw]
Subject: Re: Screwy clock after apm suspend

Mikael Pettersson <[email protected]> writes:

> I'm no longer seeing any time jumps after resumes with the
> 2.6.11-rc1 kernel. It looks like the wall_jiffies change in
> time.c fixed the bug.

i can also confirm the that the time no longer jumps after an acpi
resume with the 2.6.11-rc1 kernel.

--alex--

--
| I believe the moment is at hand when, by a paranoiac and active |
| advance of the mind, it will be possible (simultaneously with |
| automatism and other passive states) to systematize confusion |
| and thus to help to discredit completely the world of reality. |