This patch contains the following cleanups:
- make the needlessly global struct aoe_fops static
- #if 0 the unused global function aoechr_hdump
Signed-off-by: Adrian Bunk <[email protected]>
---
drivers/block/aoe/aoechr.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
--- linux-2.6.11-rc2-mm1-full/drivers/block/aoe/aoechr.c.old 2005-01-29 13:43:34.000000000 +0100
+++ linux-2.6.11-rc2-mm1-full/drivers/block/aoe/aoechr.c 2005-01-29 13:44:16.000000000 +0100
@@ -99,6 +99,8 @@
up(&emsgs_sema);
}
+#if 0
+
#define PERLINE 16
void
aoechr_hdump(char *buf, int n)
@@ -134,6 +136,8 @@
kfree(fbuf);
}
+#endif /* 0 */
+
static ssize_t
aoechr_write(struct file *filp, const char __user *buf, size_t cnt, loff_t *offp)
{
@@ -233,7 +237,7 @@
}
}
-struct file_operations aoe_fops = {
+static struct file_operations aoe_fops = {
.write = aoechr_write,
.read = aoechr_read,
.open = aoechr_open,
On Mon, Jan 31, 2005 at 09:34:58AM -0500, Ed L Cashin wrote:
> Adrian Bunk <[email protected]> writes:
>
> > This patch contains the following cleanups:
> > - make the needlessly global struct aoe_fops static
> > - #if 0 the unused global function aoechr_hdump
>
> Thanks for the patch. The original patch leaves the prototype for
> aoechr_hdump in aoe.h, but since this function is just for debugging,
> it seems better to just take both prototype and definition out.
>
>
> remove aoechr_hdump
> make aoe_fops static
>
> Signed-off-by: Ed L. Cashin <[email protected]>
Applied, thanks.
greg k-h