2005-02-03 14:16:32

by Steffen Zieger

[permalink] [raw]
Subject: [Patch] eth1394: Change KERN_ERR to KERN_INFO

Hello list,

on boot eth1394 prints the following message to KERN_ERR, but I think it is
better printing to KERN_INFO, because it _is_ an informational message only
(or: I think so).
This is the message I mean:
eth1394: eth1: IEEE-1394 IPv4 over 1394 Ethernet (fw-host0)

The patch should apply against kernel 2.6.11-rc2 cleanly

HAND,
Steffen
--
Freiheit ist die Freiheit zu sagen, dass zwei und zwei gleich vier ist.
Sobald das gew?hrleistet ist, ergibt sich alles andere von selbst.
1984 - George Orwell


Attachments:
(No filename) (0.00 B)
(No filename) (189.00 B)
Download all attachments

2005-02-04 19:09:19

by Jody McIntyre

[permalink] [raw]
Subject: Re: [Patch] eth1394: Change KERN_ERR to KERN_INFO

On Thu, Feb 03, 2005 at 03:28:41PM +0100, Steffen Zieger wrote:
> Hello list,
>
> on boot eth1394 prints the following message to KERN_ERR, but I think it is
> better printing to KERN_INFO, because it _is_ an informational message only
> (or: I think so).
> This is the message I mean:
> eth1394: eth1: IEEE-1394 IPv4 over 1394 Ethernet (fw-host0)
>
> The patch should apply against kernel 2.6.11-rc2 cleanly

1. Please add Signed-off-by (see Documentation/SubmittingPatches ).

2. Please produce patches that apply -p1.

3. Please cc [email protected].

I made a new patch that applies to linux1394 SVN. Dan, if you agree with
this change, please apply.

Thanks,
Jody

>
> HAND,
> Steffen
> --
> Freiheit ist die Freiheit zu sagen, dass zwei und zwei gleich vier ist.
> Sobald das gew?hrleistet ist, ergibt sich alles andere von selbst.
> 1984 - George Orwell

> --- drivers/ieee1394/eth1394.c.orig 2005-02-03 08:48:34.884410376 +0100
> +++ drivers/ieee1394/eth1394.c 2005-02-03 08:48:58.948752040 +0100
> @@ -626,7 +626,7 @@
> goto out;
> }
>
> - ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
> + ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
> host->id);
>
> hi->host = host;



Change the initialization message for eth1394 to KERN_INFO, requested by
Steffen Zieger <[email protected]>

Signed-off-by: Jody McIntyre <[email protected]>

Index: ieee1394/eth1394.c
===================================================================
--- ieee1394.orig/eth1394.c 2005-02-04 13:50:52.549918592 -0500
+++ ieee1394/eth1394.c 2005-02-04 13:53:04.648836504 -0500
@@ -625,7 +625,7 @@ static void ether1394_add_host (struct h
goto out;
}

- ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
+ ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
host->id);

hi->host = host;






2005-02-05 19:33:54

by Dan Dennedy

[permalink] [raw]
Subject: Re: [Patch] eth1394: Change KERN_ERR to KERN_INFO

Committed

On Fri, 2005-02-04 at 14:00 -0500, Jody McIntyre wrote:
> Change the initialization message for eth1394 to KERN_INFO, requested
> by
> Steffen Zieger <[email protected]>
>
> Signed-off-by: Jody McIntyre <[email protected]>