2005-02-10 15:43:22

by Stelian Pop

Subject: [PATCH 0/5] sonypi driver update

Hi,

Over the last few weeks I've collected a few patches in my tree
coming from others and it's time to merge them upstream:

1/5: sonypi: replace schedule_timeout() with msleep()
2/5: sonypi: add another HELP button event
3/5: sonypi: use MISC_DYNAMIC_MINOR in miscdevice.minor assignment.
4/5: sonypi: fold the contents of sonypi.h into sonypi.c
5/5: sonypi: add fan and temperature status/control

Please apply.

Thanks.

Stelian.
--
Stelian Pop <[email protected]>

2005-02-10 19:25:40

by Dmitry Torokhov

Subject: Re: [PATCH 0/5] sonypi driver update

On Thu, 10 Feb 2005 16:44:21 +0100, Stelian Pop <[email protected]> wrote:
> Hi,
>
> Over the last few weeks I've collected a few patches in my tree
> coming from others and it's time to merge them upstream:
>
> 1/5: sonypi: replace schedule_timeout() with msleep()
> 2/5: sonypi: add another HELP button event
> 3/5: sonypi: use MISC_DYNAMIC_MINOR in miscdevice.minor assignment.
> 4/5: sonypi: fold the contents of sonypi.h into sonypi.c
> 5/5: sonypi: add fan and temperature status/control

Any chance that last one could be done via sysfs attributes instead of
new IOCTLs? This way you can control fan from the command line.

--
Dmitry

2005-02-11 08:35:31

by Stelian Pop

Subject: Re: [PATCH 0/5] sonypi driver update

On Thu, Feb 10, 2005 at 02:24:58PM -0500, Dmitry Torokhov wrote:

> On Thu, 10 Feb 2005 16:44:21 +0100, Stelian Pop <[email protected]> wrote:
> > Hi,
> >
> > Over the last few weeks I've collected a few patches in my tree
> > coming from others and it's time to merge them upstream:
> >
> > 1/5: sonypi: replace schedule_timeout() with msleep()
> > 2/5: sonypi: add another HELP button event
> > 3/5: sonypi: use MISC_DYNAMIC_MINOR in miscdevice.minor assignment.
> > 4/5: sonypi: fold the contents of sonypi.h into sonypi.c
> > 5/5: sonypi: add fan and temperature status/control
>
> Any chance that last one could be done via sysfs attributes instead of
> new IOCTLs? This way you can control fan from the command line.

Good suggestion, but I'd rather not mix ioctls and sysfs attrs. In
some future version (development branch ? ahem) I'll switch to sysfs
for all the controls and implement backward compatibility in the
userspace tool.

Stelian.
--
Stelian Pop <[email protected]>