2005-02-25 00:22:33

by Andreas Schwab

[permalink] [raw]
Subject: raid6altivec does not compile on ppc32

On ppc32 cur_cpu_spec is an array of pointers, not just a pointer like on
ppc64.

drivers/md/raid6altivec1.c: In function `raid6_have_altivec':
drivers/md/raid6altivec1.c:111: error: request for member `cpu_features' in something not a structure or union

Andreas.

--
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."


2005-02-25 00:30:32

by H. Peter Anvin

[permalink] [raw]
Subject: Re: raid6altivec does not compile on ppc32

Andreas Schwab wrote:
> On ppc32 cur_cpu_spec is an array of pointers, not just a pointer like on
> ppc64.
>
> drivers/md/raid6altivec1.c: In function `raid6_have_altivec':
> drivers/md/raid6altivec1.c:111: error: request for member `cpu_features' in something not a structure or union
>

I think this is being discussed on the ppc development list. It's
apparently turned into a "we have a problem, let's fix it the right way."

-hpa

2005-02-25 00:46:10

by Olof Johansson

[permalink] [raw]
Subject: Re: raid6altivec does not compile on ppc32

On Thu, Feb 24, 2005 at 04:19:28PM -0800, H. Peter Anvin wrote:
> Andreas Schwab wrote:
> >On ppc32 cur_cpu_spec is an array of pointers, not just a pointer like on
> >ppc64.
> >
> >drivers/md/raid6altivec1.c: In function `raid6_have_altivec':
> >drivers/md/raid6altivec1.c:111: error: request for member `cpu_features'
> >in something not a structure or union
> >
>
> I think this is being discussed on the ppc development list. It's
> apparently turned into a "we have a problem, let's fix it the right way."

cpu_has_feature() is in 2.6.11-rc4-mm1, it takes care of it.


-Olof