2005-02-26 00:03:57

by Panagiotis Issaris

Subject: prism54 not releasing region

Hi,

To my newbie eye it looked as if the region requested at line 154
weren't released in case of the line 166 failure handling. Is
my assumption right?

With friendly regards,
Takis

diff -uprN linux-2.6.11-rc5-orig/drivers/net/wireless/prism54/islpci_hotplug.c linux-2.6.11-rc5-pi/drivers/net/wireless/prism54/islpci_hotplug.c
--- linux-2.6.11-rc5-orig/drivers/net/wireless/prism54/islpci_hotplug.c 2005-02-26 00:33:19.000000000 +0100
+++ linux-2.6.11-rc5-pi/drivers/net/wireless/prism54/islpci_hotplug.c 2005-02-26 00:34:13.000000000 +0100
@@ -163,7 +163,7 @@ prism54_probe(struct pci_dev *pdev, cons
if (rvalue || !mem_addr) {
printk(KERN_ERR "%s: PCI device memory region not configured; fix your BIOS or CardBus bridge/drivers\n",
DRV_NAME);
- goto do_pci_disable_device;
+ goto do_pci_release_regions;
}

/* enable PCI bus-mastering */

--
OpenPGP key: http://lumumba.luc.ac.be/takis/takis_public_key.txt
fingerprint: 6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029

2005-02-26 00:35:55

by Andrew Morton

Subject: Re: prism54 not releasing region

Panagiotis Issaris <[email protected]> wrote:
>
> To my newbie eye it looked as if the region requested at line 154
> weren't released in case of the line 166 failure handling. Is
> my assumption right?

It is. I can take care of this patch for you, thanks.

2005-02-26 00:44:50

by Panagiotis Issaris

Subject: Re: prism54 not releasing region

Andrew Morton wrote:

>Panagiotis Issaris <[email protected]> wrote:
>
>
>>To my newbie eye it looked as if the region requested at line 154
>>weren't released in case of the line 166 failure handling. Is
>>my assumption right?
>>
>>
>
>It is. I can take care of this patch for you, thanks.
>
>
Great! :-) Thanks!

With friendly regards,
Takis

--
K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group
http://people.mech.kuleuven.ac.be/~pissaris/