2005-03-14 00:28:40

by maximilian attems

Subject: [patch] elsa eliminate bad section references

Fix elsa section references:
convert __initdata to __devinitdata.

Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d28 R_386_32
.init.data
Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d37 R_386_32
.init.data
Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d56 R_386_32
.init.data
Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d77 R_386_32
.init.data
Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003ddb R_386_32
.init.data
Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003e0e R_386_32
.init.data
Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003e20 R_386_32
.init.data

Signed-off-by: maximilian attems <[email protected]>


diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/elsa.c
linux-2.6.11-bk8-max/drivers/isdn/hisax/elsa.c
--- linux-2.6.11-bk8/drivers/isdn/hisax/elsa.c 2005-03-02 08:37:49.000000000 +0100
+++ linux-2.6.11-bk8-max/drivers/isdn/hisax/elsa.c 2005-03-14 01:04:02.000000000 +0100
@@ -838,7 +838,7 @@ static struct pci_dev *dev_qs1000 __dev
static struct pci_dev *dev_qs3000 __devinitdata = NULL;

#ifdef __ISAPNP__
-static struct isapnp_device_id elsa_ids[] __initdata = {
+static struct isapnp_device_id elsa_ids[] __devinitdata = {
{ ISAPNP_VENDOR('E', 'L', 'S'), ISAPNP_FUNCTION(0x0133),
ISAPNP_VENDOR('E', 'L', 'S'), ISAPNP_FUNCTION(0x0133),
(unsigned long) "Elsa QS1000" },
@@ -848,7 +848,7 @@ static struct isapnp_device_id elsa_ids[
{ 0, }
};

-static struct isapnp_device_id *ipid __initdata = &elsa_ids[0];
+static struct isapnp_device_id *ipid __devinitdata = &elsa_ids[0];
static struct pnp_card *pnp_c __devinitdata = NULL;
#endif

2005-03-14 22:37:17

by Randy.Dunlap

Subject: Re: [patch] elsa eliminate bad section references

maximilian attems wrote:
> Fix elsa section references:
> convert __initdata to __devinitdata.
>
> Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d28 R_386_32
> .init.data
> Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d37 R_386_32
> .init.data
> Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d56 R_386_32
> .init.data
> Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003d77 R_386_32
> .init.data
> Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003ddb R_386_32
> .init.data
> Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003e0e R_386_32
> .init.data
> Error: ./drivers/isdn/hisax/elsa.o .text refers to 00003e20 R_386_32
> .init.data
>
> Signed-off-by: maximilian attems <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/elsa.c
> linux-2.6.11-bk8-max/drivers/isdn/hisax/elsa.c
> --- linux-2.6.11-bk8/drivers/isdn/hisax/elsa.c 2005-03-02 08:37:49.000000000 +0100
> +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/elsa.c 2005-03-14 01:04:02.000000000 +0100
> @@ -838,7 +838,7 @@ static struct pci_dev *dev_qs1000 __dev
> static struct pci_dev *dev_qs3000 __devinitdata = NULL;
>
> #ifdef __ISAPNP__
> -static struct isapnp_device_id elsa_ids[] __initdata = {
> +static struct isapnp_device_id elsa_ids[] __devinitdata = {
> { ISAPNP_VENDOR('E', 'L', 'S'), ISAPNP_FUNCTION(0x0133),
> ISAPNP_VENDOR('E', 'L', 'S'), ISAPNP_FUNCTION(0x0133),
> (unsigned long) "Elsa QS1000" },
> @@ -848,7 +848,7 @@ static struct isapnp_device_id elsa_ids[
> { 0, }
> };
>
> -static struct isapnp_device_id *ipid __initdata = &elsa_ids[0];
> +static struct isapnp_device_id *ipid __devinitdata = &elsa_ids[0];
> static struct pnp_card *pnp_c __devinitdata = NULL;
> #endif
>


--
~Randy