2005-03-14 10:55:42

by Peter Hagervall

Subject: [PATCH] drivers/media Sparse fixes

Removes some sparse warnings on one-bit bitfields.

Signed-off-by: Peter Hagervall <[email protected]>

--

dvb/dvb-core/dvb_ca_en50221.c | 6 +++---
video/cx88/cx88.h | 4 ++--
video/msp3400.c | 4 ++--
video/videocodec.h | 16 ++++++++--------
4 files changed, 15 insertions(+), 15 deletions(-)


===== drivers/media/dvb/dvb-core/dvb_ca_en50221.c 1.10 vs edited =====
--- 1.10/drivers/media/dvb/dvb-core/dvb_ca_en50221.c 2005-03-14 00:29:37 +01:00
+++ edited/drivers/media/dvb/dvb-core/dvb_ca_en50221.c 2005-03-14 11:40:56 +01:00
@@ -148,13 +148,13 @@
wait_queue_head_t thread_queue;

/* Flag indicating when thread should exit */
- int exit:1;
+ unsigned int exit:1;

/* Flag indicating if the CA device is open */
- int open:1;
+ unsigned int open:1;

/* Flag indicating the thread should wake up now */
- int wakeup:1;
+ unsigned int wakeup:1;

/* Delay the main thread should use */
unsigned long delay;
===== drivers/media/video/msp3400.c 1.34 vs edited =====
--- 1.34/drivers/media/video/msp3400.c 2005-01-25 22:50:27 +01:00
+++ edited/drivers/media/video/msp3400.c 2005-03-14 11:38:24 +01:00
@@ -97,8 +97,8 @@
/* thread */
struct task_struct *kthread;
wait_queue_head_t wq;
- int restart:1;
- int watch_stereo:1;
+ unsigned int restart:1;
+ unsigned int watch_stereo:1;
};

#define HAVE_NICAM(msp) (((msp->rev2>>8) & 0xff) != 00)
===== drivers/media/video/videocodec.h 1.3 vs edited =====
--- 1.3/drivers/media/video/videocodec.h 2005-01-05 03:48:33 +01:00
+++ edited/drivers/media/video/videocodec.h 2005-03-14 11:37:28 +01:00
@@ -222,14 +222,14 @@
/* ========================= */

struct vfe_polarity {
- int vsync_pol:1;
- int hsync_pol:1;
- int field_pol:1;
- int blank_pol:1;
- int subimg_pol:1;
- int poe_pol:1;
- int pvalid_pol:1;
- int vclk_pol:1;
+ unsigned int vsync_pol:1;
+ unsigned int hsync_pol:1;
+ unsigned int field_pol:1;
+ unsigned int blank_pol:1;
+ unsigned int subimg_pol:1;
+ unsigned int poe_pol:1;
+ unsigned int pvalid_pol:1;
+ unsigned int vclk_pol:1;
};

struct vfe_settings {
===== drivers/media/video/cx88/cx88.h 1.8 vs edited =====
--- 1.8/drivers/media/video/cx88/cx88.h 2005-03-11 21:32:23 +01:00
+++ edited/drivers/media/video/cx88/cx88.h 2005-03-14 11:39:36 +01:00
@@ -188,8 +188,8 @@
int tda9887_conf;
struct cx88_input input[8];
struct cx88_input radio;
- int blackbird:1;
- int dvb:1;
+ unsigned int blackbird:1;
+ unsigned int dvb:1;
};

struct cx88_subid {

2005-03-16 21:21:22

by Johannes Stezenbach

Subject: Re: [PATCH] drivers/media Sparse fixes

On Mon, Mar 14, 2005 at 11:55:24AM +0100, Peter Hagervall wrote:
> Removes some sparse warnings on one-bit bitfields.
>
> Signed-off-by: Peter Hagervall <[email protected]>
>
> --
>
> dvb/dvb-core/dvb_ca_en50221.c | 6 +++---

I applied this one to linuxtv.org CVS.

> video/cx88/cx88.h | 4 ++--
> video/msp3400.c | 4 ++--
> video/videocodec.h | 16 ++++++++--------

These should go to the video4linux maintainer...

Thanks,
Johannes