2005-03-15 00:07:17

by Randy.Dunlap

[permalink] [raw]
Subject: [PATCH] procfs: convert to C99 inits.

(resend)

Use C99 struct inits as requested by sparse:
fs/proc/base.c:738:2: warning: obsolete struct initializer, use C99 syntax
fs/proc/base.c:739:2: warning: obsolete struct initializer, use C99 syntax

Signed-off-by: Randy Dunlap <[email protected]>

diffstat:=
fs/proc/base.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -Naurp ./fs/proc/base.c~proc_c99_inits ./fs/proc/base.c
--- ./fs/proc/base.c~proc_c99_inits 2005-02-15 13:48:46.310312808 -0800
+++ ./fs/proc/base.c 2005-02-15 20:34:41.335786152 -0800
@@ -735,8 +735,8 @@ static ssize_t oom_adjust_write(struct f
}

static struct file_operations proc_oom_adjust_operations = {
- read: oom_adjust_read,
- write: oom_adjust_write,
+ .read = oom_adjust_read,
+ .write = oom_adjust_write,
};

static struct inode_operations proc_mem_inode_operations = {


---


2005-03-15 00:17:46

by Ben Dooks

[permalink] [raw]
Subject: Re: [PATCH] procfs: convert to C99 inits.

On Mon, Mar 14, 2005 at 04:03:29PM -0800, Randy.Dunlap wrote:
> (resend)
>
> Use C99 struct inits as requested by sparse:
> fs/proc/base.c:738:2: warning: obsolete struct initializer, use C99 syntax
> fs/proc/base.c:739:2: warning: obsolete struct initializer, use C99 syntax

I posted a patch for this, and an included `__user` missing
from the self-same set of functions a short while ago.

--
Ben ([email protected], http://www.fluff.org/)

'a smiley only costs 4 bytes'

2005-03-15 00:22:25

by Randy.Dunlap

[permalink] [raw]
Subject: Re: [PATCH] procfs: convert to C99 inits.

Ben Dooks wrote:
> On Mon, Mar 14, 2005 at 04:03:29PM -0800, Randy.Dunlap wrote:
>
>>(resend)
>>
>>Use C99 struct inits as requested by sparse:
>>fs/proc/base.c:738:2: warning: obsolete struct initializer, use C99 syntax
>>fs/proc/base.c:739:2: warning: obsolete struct initializer, use C99 syntax
>
>
> I posted a patch for this, and an included `__user` missing
> from the self-same set of functions a short while ago.

Sounds better. I hadn't noticed that part...

--
~Randy