2005-03-15 00:08:45

by Randy.Dunlap

Subject: [PATCH] mtd: use unsigned 1-bit fields

(resend)

Fix (22) bitfield/boolean sparse warnings:
include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield
include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield

Signed-off-by: Randy Dunlap <[email protected]>

diffstat:=
include/linux/mtd/flashchip.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff -Naurp ./include/linux/mtd/flashchip.h~mtd_flashchip_bool ./include/linux/mtd/flashchip.h
--- ./include/linux/mtd/flashchip.h~mtd_flashchip_bool 2005-02-15 13:48:46.633263712 -0800
+++ ./include/linux/mtd/flashchip.h 2005-02-15 20:25:20.924981544 -0800
@@ -62,8 +62,8 @@ struct flchip {
flstate_t state;
flstate_t oldstate;

- int write_suspended:1;
- int erase_suspended:1;
+ unsigned int write_suspended:1;
+ unsigned int erase_suspended:1;
unsigned long in_progress_block_addr;

spinlock_t *mutex;


---

2005-03-15 00:17:45

by Ben Dooks

Subject: Re: [PATCH] mtd: use unsigned 1-bit fields

On Mon, Mar 14, 2005 at 04:07:01PM -0800, Randy.Dunlap wrote:
> (resend)
>
> Fix (22) bitfield/boolean sparse warnings:
> include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield
> include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield

caught in the mtd-cvs, so it depends if you want to
wait for the next mtd merge or not.

--
Ben ([email protected], http://www.fluff.org/)

'a smiley only costs 4 bytes'

2005-03-15 00:27:03

by Randy.Dunlap

Subject: Re: [PATCH] mtd: use unsigned 1-bit fields

Ben Dooks wrote:
> On Mon, Mar 14, 2005 at 04:07:01PM -0800, Randy.Dunlap wrote:
>
>>(resend)
>>
>>Fix (22) bitfield/boolean sparse warnings:
>>include/linux/mtd/flashchip.h:65:23: warning: dubious one-bit signed bitfield
>>include/linux/mtd/flashchip.h:66:23: warning: dubious one-bit signed bitfield
>
>
> caught in the mtd-cvs, so it depends if you want to
> wait for the next mtd merge or not.

That's fine by me. I didn't know it had made it to the mtd-cvs.

Thanks for the message.

--
~Randy