2005-03-01 00:38:14

by Adrian Bunk

Subject: [2.6 patch] drivers/usb/net/pegasus.c: make some code static

This patch makes some needlessly global code static.

Signed-off-by: Adrian Bunk <[email protected]>

---

drivers/usb/net/pegasus.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)

--- linux-2.6.11-rc4-mm1-full/drivers/usb/net/pegasus.c.old 2005-02-28 23:26:58.000000000 +0100
+++ linux-2.6.11-rc4-mm1-full/drivers/usb/net/pegasus.c 2005-02-28 23:27:45.000000000 +0100
@@ -956,7 +956,8 @@
return 0;
}

-void pegasus_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
+static void pegasus_get_drvinfo(struct net_device *dev,
+ struct ethtool_drvinfo *info)
{
pegasus_t *pegasus = netdev_priv(dev);
strncpy(info->driver, driver_name, sizeof (info->driver) - 1);
@@ -1156,10 +1157,10 @@
}


-struct workqueue_struct *pegasus_workqueue = NULL;
+static struct workqueue_struct *pegasus_workqueue = NULL;
#define CARRIER_CHECK_DELAY (2 * HZ)

-void check_carrier(void *data)
+static void check_carrier(void *data)
{
pegasus_t *pegasus = data;
set_carrier(pegasus->net);

2005-03-01 09:18:54

by Petko Manolov

Subject: Re: [2.6 patch] drivers/usb/net/pegasus.c: make some code static

That's reasonable. Thanks for the patch.


Petko



On Tue, 1 Mar 2005, Adrian Bunk wrote:

> This patch makes some needlessly global code static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> drivers/usb/net/pegasus.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> --- linux-2.6.11-rc4-mm1-full/drivers/usb/net/pegasus.c.old 2005-02-28 23:26:58.000000000 +0100
> +++ linux-2.6.11-rc4-mm1-full/drivers/usb/net/pegasus.c 2005-02-28 23:27:45.000000000 +0100
> @@ -956,7 +956,8 @@
> return 0;
> }
>
> -void pegasus_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
> +static void pegasus_get_drvinfo(struct net_device *dev,
> + struct ethtool_drvinfo *info)
> {
> pegasus_t *pegasus = netdev_priv(dev);
> strncpy(info->driver, driver_name, sizeof (info->driver) - 1);
> @@ -1156,10 +1157,10 @@
> }
>
>
> -struct workqueue_struct *pegasus_workqueue = NULL;
> +static struct workqueue_struct *pegasus_workqueue = NULL;
> #define CARRIER_CHECK_DELAY (2 * HZ)
>
> -void check_carrier(void *data)
> +static void check_carrier(void *data)
> {
> pegasus_t *pegasus = data;
> set_carrier(pegasus->net);
>
>

2005-03-18 01:21:19

by Greg KH

Subject: Re: [2.6 patch] drivers/usb/net/pegasus.c: make some code static

On Tue, Mar 01, 2005 at 01:35:41AM +0100, Adrian Bunk wrote:
> This patch makes some needlessly global code static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Applied, thanks.

greg k-h